Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1228229

Re: [PATCH] irq_remapping: move structs outside #ifdef

Path csiph.com!au2pb.net!feeder.erje.net!1.eu.feeder.erje.net!gandalf.srv.welterde.de!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH] irq_remapping: move structs outside #ifdef
Date Fri, 18 Sep 2015 20:50:02 +0200
Message-ID <qa8To-2tx-15@gated-at.bofh.it> (permalink)
References <qa6oy-7wu-23@gated-at.bofh.it>
X-Original-To Paolo Bonzini <pbonzini@redhat.com>
User-Agent Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version 1.0
Content-Type TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score -1.0
X-Linutronix-Spam-Level -
X-Linutronix-Spam-Status No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 56
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>, Jiang Liu <jiang.liu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, Feng Wu <feng.wu@intel.com>
X-Original-Date Fri, 18 Sep 2015 20:43:36 +0200 (CEST)
X-Original-Message-ID <alpine.DEB.2.11.1509182043280.3951@nanos>
X-Original-References <1442592379-12021-1-git-send-email-pbonzini@redhat.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1228229

Show key headers only | View raw



On Fri, 18 Sep 2015, Paolo Bonzini wrote:

> This is friendlier to clients of the code, who are going to prepare
> vcpu_data structs unconditionally, even if CONFIG_IRQ_REMAP is not
> defined.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

> ---
> 	Please ack, I'd like to include it in the 4.4 pull request.
> 
>  arch/x86/include/asm/irq_remapping.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/include/asm/irq_remapping.h b/arch/x86/include/asm/irq_remapping.h
> index 046c7fb1ca43..a210eba2727c 100644
> --- a/arch/x86/include/asm/irq_remapping.h
> +++ b/arch/x86/include/asm/irq_remapping.h
> @@ -33,6 +33,11 @@ enum irq_remap_cap {
>  	IRQ_POSTING_CAP = 0,
>  };
>  
> +struct vcpu_data {
> +	u64 pi_desc_addr;	/* Physical address of PI Descriptor */
> +	u32 vector;		/* Guest vector of the interrupt */
> +};
> +
>  #ifdef CONFIG_IRQ_REMAP
>  
>  extern bool irq_remapping_cap(enum irq_remap_cap cap);
> @@ -58,11 +63,6 @@ static inline struct irq_domain *arch_get_ir_parent_domain(void)
>  	return x86_vector_domain;
>  }
>  
> -struct vcpu_data {
> -	u64 pi_desc_addr;	/* Physical address of PI Descriptor */
> -	u32 vector;		/* Guest vector of the interrupt */
> -};
> -
>  #else  /* CONFIG_IRQ_REMAP */
>  
>  static inline bool irq_remapping_cap(enum irq_remap_cap cap) { return 0; }
> -- 
> 1.8.3.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] irq_remapping: move structs outside #ifdef Paolo Bonzini <pbonzini@redhat.com> - 2015-09-18 18:10 +0200
  Re: [PATCH] irq_remapping: move structs outside #ifdef Thomas Gleixner <tglx@linutronix.de> - 2015-09-18 20:50 +0200

csiph-web