Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228188

Re: [PATCH] usb: chipidea: udc: improve error handling on ep_queue and f_midi

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Fri, Sep 18, 2015 at 05:48:45PM +0100, eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
> 
> _ep_queue() didn't check for errors when using add_td_to_list()
> which can fail if dma_pool_alloc fails, thus causing a kernel
> panic when lastnode->ptr is NULL.
> 
> Also f_midi is not checking weather the is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>  drivers/usb/chipidea/udc.c           | 26 +++++++++++++++++++-------
>  drivers/usb/gadget/function/f_midi.c | 11 +++++++++--

why are you patching f_midi.c in a chipidea patch ? Have a read at
Documentation/SubmittingPatches, Documentation/SubmitChecklist

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: chipidea: udc: improve error handling on ep_queue and f_midi eu@felipetonello.com - 2015-09-18 18:50 +0200
  Re: [PATCH] usb: chipidea: udc: improve error handling on ep_queue  and f_midi Felipe Balbi <balbi@ti.com> - 2015-09-18 19:10 +0200

csiph-web