Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1228132

Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets

Path csiph.com!goblin3!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From Chen-Yu Tsai <wens@csie.org>
Newsgroups linux.kernel
Subject Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets
Date Fri, 18 Sep 2015 18:30:01 +0200
Message-ID <qa6HT-7Th-7@gated-at.bofh.it> (permalink)
References <q9YqZ-4pF-3@gated-at.bofh.it> <q9YqZ-4pF-1@gated-at.bofh.it> <qa5Vw-6Jf-19@gated-at.bofh.it>
X-Original-To Hans de Goede <hdegoede@redhat.com>
X-Received by 10.50.92.69 with SMTP id ck5mr13524718igb.3.1442593539909; Fri, 18 Sep 2015 09:25:39 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 47
Organization linux.* mail to news gateway
X-Original-Cc Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <maxime.ripard@free-electrons.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-sunxi <linux-sunxi@googlegroups.com>
X-Original-Date Sat, 19 Sep 2015 00:25:20 +0800
X-Original-Message-ID <CAGb2v65kEqxiWLz_faQzMWFP0nHY_tv-aJCZGNQJjYFbGEn8rQ@mail.gmail.com>
X-Original-References <1442561739-6824-1-git-send-email-wens@csie.org> <1442561739-6824-4-git-send-email-wens@csie.org> <55FC2E95.7040006@redhat.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1228132

Show key headers only | View raw


On Fri, Sep 18, 2015 at 11:32 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote:
>>
>> A23/A33 based Q8 format tablets use channel 0 of the PWM controller for
>> backlight dimming.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>>   arch/arm/boot/dts/sun8i-q8-common.dtsi | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-q8-common.dtsi
>> b/arch/arm/boot/dts/sun8i-q8-common.dtsi
>> index 6f8a8bb4e9bb..4c2d0b459d6f 100644
>> --- a/arch/arm/boot/dts/sun8i-q8-common.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-q8-common.dtsi
>> @@ -70,6 +70,12 @@
>>         };
>>   };
>>
>> +&pwm {
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pwm0_pins>;
>> +       status = "okay";
>> +};
>> +
>>   &r_uart {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&r_uart_pins_a>;
>>
>
> I've a feeling this should be in sunxi-q8-common.dtsi not
> sun8i-q8-common.dtsi, which requires adding a pwm
> node to sun5i.dtsi I'll look into this.

It probably should. IIRC sun5i PWM has only one channel as opposed to
2 on A10/A20.


ChenYu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets Chen-Yu Tsai <wens@csie.org> - 2015-09-18 09:40 +0200
  Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller  on A23/A33 Q8 format tablets Hans de Goede <hdegoede@redhat.com> - 2015-09-18 17:40 +0200
    Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller  on A23/A33 Q8 format tablets Chen-Yu Tsai <wens@csie.org> - 2015-09-18 18:30 +0200
      Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller  on A23/A33 Q8 format tablets Hans de Goede <hdegoede@redhat.com> - 2015-09-19 23:40 +0200

csiph-web