Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228088

Re: [PATCH 01/17] Add ida and idr helper routines.

Show all headers | View raw

On 09/15/2015 11:41 AM, Tejun Heo wrote:
> Hello,
> 
> On Tue, Sep 15, 2015 at 11:38:42AM -0700, James Bottomley wrote:
>> For most of the SCSI stuff, yes.  I'm less sure about the sd numbers.
>> They go up very high and get hammered a lot during system bring up and
>> hot plug.  I think having their own lock rather than wrapping everything
>> around simple_ida_lock makes more sense here just because the system is
>> heavily contended on getting indexes at bring up.
>>
>> To continue the thought, why not move simple_ida_lock into struct ida so
>> we don't have to worry about the contention and can sue ida_simple_...
>> everywhere?
> 
> We sure can do that if necessary but I'm rather doubtful that even
> with sd number hammering this is likely to be a problem.  Let's
> convert the users to the simple interface and make the lock per-ida if
> we actually see contention on the lock.
> 
> Thanks.
> 

To be clear: you would like a patch series that converts the users of
the ida_* routines in my patches to instead use the ida_simple_*
routines, correct? And of course the ida_* helper routines I was adding
in idr.h would not be needed.

If this is correct, I will supply a version 2 patch series that
addresses this issue as well as the two patch-naming issues that were
raised.
-- 
Lee Duncan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/17] Create and use ida and idr helper routines Lee Duncan <lduncan@suse.com> - 2015-09-15 19:00 +0200
  [PATCH 04/17] Update the ch driver to use idr helper functions. Lee Duncan <lduncan@suse.com> - 2015-09-15 19:00 +0200
  [PATCH 11/17] Update the rtsx multifunction driver to use idr helper functions. Lee Duncan <lduncan@suse.com> - 2015-09-15 19:00 +0200
  [PATCH 12/17] Update the TI Flash Media driver to use idr helper functions. Lee Duncan <lduncan@suse.com> - 2015-09-15 19:00 +0200
  [PATCH 02/17] Update scsi hosts to use idr for host number mgmt Lee Duncan <lduncan@suse.com> - 2015-09-15 19:00 +0200
  [PATCH 01/17] Add ida and idr helper routines. Lee Duncan <lduncan@suse.com> - 2015-09-15 19:00 +0200
    Re: [PATCH 01/17] Add ida and idr helper routines. James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-15 20:30 +0200
    Re: [PATCH 01/17] Add ida and idr helper routines. Tejun Heo <tj@kernel.org> - 2015-09-15 20:30 +0200
      Re: [PATCH 01/17] Add ida and idr helper routines. James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-15 20:40 +0200
        Re: [PATCH 01/17] Add ida and idr helper routines. Tejun Heo <tj@kernel.org> - 2015-09-15 20:50 +0200
          Re: [PATCH 01/17] Add ida and idr helper routines. Tejun Heo <tj@kernel.org> - 2015-09-18 17:50 +0200
          Re: [PATCH 01/17] Add ida and idr helper routines. Lee Duncan <lduncan@suse.com> - 2015-09-18 17:50 +0200
  [PATCH 03/17] Update the st driver to use idr helper functions. Lee Duncan <lduncan@suse.com> - 2015-09-15 19:00 +0200
  [PATCH 10/17] Update the DCA DMA driver to use idr helper functions. Lee Duncan <lduncan@suse.com> - 2015-09-15 19:00 +0200

csiph-web