Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1227834

[PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg

Show all headers | View raw

The sane_reclaim() helper is supposed to return false for memcg reclaim
if the legacy hierarchy is used, because the latter lacks dirty
throttling mechanism, and so it did before it was accidentally broken by
commit 33398cf2f360c ("memcg: export struct mem_cgroup"). Fix it.

Fixes: 33398cf2f360c ("memcg: export struct mem_cgroup")
Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
---
 mm/vmscan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index db5339dd4a32..dbc3b3ae48de 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -175,7 +175,7 @@ static bool sane_reclaim(struct scan_control *sc)
 	if (!memcg)
 		return true;
 #ifdef CONFIG_CGROUP_WRITEBACK
-	if (memcg->css.cgroup)
+	if (cgroup_on_dfl(memcg->css.cgroup))
 		return true;
 #endif
 	return false;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg Vladimir Davydov <vdavydov@parallels.com> - 2015-09-18 14:50 +0200
  Re: [PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg Tejun Heo <tj@kernel.org> - 2015-09-18 15:40 +0200
  Re: [PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg Michal Hocko <mhocko@kernel.org> - 2015-09-18 16:10 +0200
  Re: [PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg Tejun Heo <tj@kernel.org> - 2015-09-18 18:00 +0200

csiph-web