Re: [PATCH 1/3] ASoC: wm0010: disable regulator on error

From	Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ASoC: wm0010: disable regulator on error
Date	2015-09-18 15:10 +0200
Message-ID	<qa3Am-3u2-17@gated-at.bofh.it> (permalink)
References	<qa1fc-8td-7@gated-at.bofh.it> <qa2uC-1IY-17@gated-at.bofh.it> <qa3gZ-2Sw-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 18, 2015 at 06:12:05PM +0530, Sudip Mukherjee wrote:
> On Fri, Sep 18, 2015 at 12:34:12PM +0100, Charles Keepax wrote:
> > On Fri, Sep 18, 2015 at 04:02:19PM +0530, Sudip Mukherjee wrote:
> > > We have done regulator_bulk_enable() while booting the DSP but on the
> > > error exit path we have not disbled it.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > > ---
> > >  sound/soc/codecs/wm0010.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
> > > index 8434d45..79a7cd3 100644
> > > --- a/sound/soc/codecs/wm0010.c
> > > +++ b/sound/soc/codecs/wm0010.c
> > > @@ -739,8 +739,6 @@ static int wm0010_boot(struct snd_soc_codec *codec)
> > >  abort:
> > >  	/* Put the chip back into reset */
> > >  	wm0010_halt(codec);
> > > -	mutex_unlock(&wm0010->lock);
> > > -	return ret;
> > 
> > Does wm0010_halt not disable the regulators?
> oops, yes, it does. Sorry I should have seen it before posting.
> patch 2/3 and 3/3 will still apply even if this 1/3 is not applied.
> Should I send a v2 leaving out this patch or is it ok to discard this
> patch while applying?

As long as they apply cleanly I would think its fine to just
leave them as is.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] ASoC: wm0010: disable regulator on error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-18 12:40 +0200
  [PATCH 2/3] ASoC: wm0010: fix memory leak Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-18 12:40 +0200
    Re: [PATCH 2/3] ASoC: wm0010: fix memory leak Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-09-18 14:10 +0200
  [PATCH 3/3] ASoC: wm0010: fix error path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-18 12:40 +0200
    Re: [PATCH 3/3] ASoC: wm0010: fix error path Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-09-18 14:10 +0200
  Re: [PATCH 1/3] ASoC: wm0010: disable regulator on error Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-09-18 14:00 +0200
    Re: [PATCH 1/3] ASoC: wm0010: disable regulator on error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-18 14:50 +0200
      Re: [PATCH 1/3] ASoC: wm0010: disable regulator on error Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-09-18 15:10 +0200

csiph-web