Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1227738

Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting

From Marc Zyngier <marc.zyngier@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting
Date 2015-09-18 12:10 +0200
Message-ID <qa0Ma-7VN-27@gated-at.bofh.it> (permalink)
References <q9OL0-7kB-15@gated-at.bofh.it> <q9RSx-3n6-3@gated-at.bofh.it> <q9ZQ6-6yg-29@gated-at.bofh.it> <qa09t-6UG-21@gated-at.bofh.it>
Organization ARM Ltd

Show all headers | View raw


On Fri, 18 Sep 2015 18:22:07 +0900
Kohji Okuno <okuno.kohji@jp.panasonic.com> wrote:

> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Fri, 18 Sep 2015 11:04:23 +0200
> > That's weird. The flow is:
> > 
> > interrupt()
> >   mask()
> >   ret = primary_handler()
> >   if (ret == WAKE_THREAD)
> >     wake_thread()
> >   else
> >     unmask()
> > 
> > thread_handler()
> >   ....
> >   unmask()
> > 
> > So if an interrupt is triggered on the device while the interrupt is
> > masked it should be raised again immediately when the unmask happens
> > because its level type.
> > 
> > I'm wondering why that doesn't work.
> 
> Yes. I think so. And, I have just found that sdhci_thread_irq() don't
> finish in this case. I'm analyzing about this now. But, after I apply
> my patch, sdhci_thread_irq() can finish. I will share the result with
> you.

What do you mean exactly by "don't finish"? Does it hang somewhere? Or
keeps processing data but never drains?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Kohji Okuno <okuno.kohji@jp.panasonic.com> - 2015-09-17 09:40 +0200
  Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Thomas Gleixner <tglx@linutronix.de> - 2015-09-17 10:10 +0200
    Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Kohji Okuno <okuno.kohji@jp.panasonic.com> - 2015-09-17 10:30 +0200
      Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Kohji Okuno <okuno.kohji@jp.panasonic.com> - 2015-09-17 11:50 +0200
        Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Thomas Gleixner <tglx@linutronix.de> - 2015-09-17 23:20 +0200
          Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Kohji Okuno <okuno.kohji@jp.panasonic.com> - 2015-09-18 02:40 +0200
            Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Thomas Gleixner <tglx@linutronix.de> - 2015-09-18 11:10 +0200
              Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Kohji Okuno <okuno.kohji@jp.panasonic.com> - 2015-09-18 11:30 +0200
                Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Marc Zyngier <marc.zyngier@arm.com> - 2015-09-18 12:10 +0200
                Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Kohji Okuno <okuno.kohji@jp.panasonic.com> - 2015-09-18 13:00 +0200
                Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Thomas Gleixner <tglx@linutronix.de> - 2015-09-18 16:50 +0200
                Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Kohji Okuno <okuno.kohji@jp.panasonic.com> - 2015-09-19 17:40 +0200
                Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Thomas Gleixner <tglx@linutronix.de> - 2015-09-19 22:30 +0200
                Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Kohji Okuno <okuno.kohji@jp.panasonic.com> - 2015-09-20 02:30 +0200

csiph-web