Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource
Date	2016-02-07 12:50 +0100
Message-ID	<qZw0N-5va-1@gated-at.bofh.it> (permalink)
References	<qZjmV-5lc-1@gated-at.bofh.it> <qZv4K-4R0-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:

>> Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse
>
>    Fixes: tag here?
Heuh no. It doesn't fix this commit, it uses a feature brought by this commit.

>> +	if (irq_get_trigger_type(dev->irq) == IRQF_TRIGGER_NONE)
>>   		dev_warn(db->dev, "WARNING: no IRQ resource flags set.\n");
>>
>>   	irqflags |= IRQF_SHARED;
>
>    Why not just initialize to IRQF_SHARED?
>    But actually you don't need this variable anymore.
Yeah, makes sense.

Cheers.

-- 
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] net: ethernet: davicom: fix devicetree irq resource Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-06 23:20 +0100
  Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource Francois Romieu <romieu@fr.zoreil.com> - 2016-02-07 11:30 +0100
    Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-07 11:50 +0100
      Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource Francois Romieu <romieu@fr.zoreil.com> - 2016-02-07 13:40 +0100
  Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-07 11:50 +0100
    Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-07 12:50 +0100

csiph-web