Re: [PATCH] Staging:iio:Remove exceptional & on function name

Path	csiph.com!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.datemas.de!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging:iio:Remove exceptional & on function name
Date	Sat, 06 Feb 2016 19:20:01 +0100
Message-ID	<qZfCF-2F1-3@gated-at.bofh.it> (permalink)
References	<qYFIS-3fA-11@gated-at.bofh.it>
X-Enigmail-Draft-Status	N1110
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	57
Organization	linux.* mail to news gateway
X-Original-Cc	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 6 Feb 2016 18:19:06 +0000
X-Original-Message-ID	<56B6391A.9040508@kernel.org>
X-Original-References	<1454644412-6861-1-git-send-email-bhumirks@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1328345

Show key headers only | View raw

On 05/02/16 03:53, Bhumika Goyal wrote:
> In this file,function names are otherwise used as pointers without &.
> Found using coccinelle.
> // <smpl>
> @r@
> identifier f;
> @@
> 
> f(...) { ... }
> @@
> identifier r.f;
> @@
> 
> - &f
> + f
> // </smpl>
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Nice little bit of tidying up.

Applied to the togreg branch of iio.git -  initially pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/impedance-analyzer/ad5933.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 10c43dda..d1218d8 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -558,7 +558,7 @@ out:
>  }
>  
>  static const struct iio_info ad5933_info = {
> -	.read_raw = &ad5933_read_raw,
> +	.read_raw = ad5933_read_raw,
>  	.attrs = &ad5933_attribute_group,
>  	.driver_module = THIS_MODULE,
>  };
> @@ -616,9 +616,9 @@ static int ad5933_ring_postdisable(struct iio_dev *indio_dev)
>  }
>  
>  static const struct iio_buffer_setup_ops ad5933_ring_setup_ops = {
> -	.preenable = &ad5933_ring_preenable,
> -	.postenable = &ad5933_ring_postenable,
> -	.postdisable = &ad5933_ring_postdisable,
> +	.preenable = ad5933_ring_preenable,
> +	.postenable = ad5933_ring_postenable,
> +	.postdisable = ad5933_ring_postdisable,
>  };
>  
>  static int ad5933_register_ring_funcs_and_init(struct iio_dev *indio_dev)
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging:iio:Remove exceptional & on function name Bhumika Goyal <bhumirks@gmail.com> - 2016-02-05 05:00 +0100
  Re: [PATCH] Staging:iio:Remove exceptional & on function name Jonathan Cameron <jic23@kernel.org> - 2016-02-06 19:20 +0100

csiph-web