Re: [PATCH] Kbuild: provide a __UNIQUE_ID for clang

From	Michal Marek <mmarek@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Kbuild: provide a __UNIQUE_ID for clang
Date	2016-02-08 19:20 +0100
Message-ID	<qZYzM-v9-7@gated-at.bofh.it> (permalink)
References	<qZV8S-6zW-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 08, 2016 at 03:38:32PM +0100, Arnd Bergmann wrote:
> The default __UNIQUE_ID macro in compiler.h fails to work for some drivers:
> 
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:615:1: error: redefinition of
>       '__UNIQUE_ID_firmware615'
> BRCMF_FW_NVRAM_DEF(4354, "brcmfmac4354-sdio.bin", "brcmfmac4354-sdio.txt");

I applied the patch to kbuild.git#kbuild, but can you tell me with which
commit and config you get such failure. I only see a single
MODULE_FIRMWARE() call in the expansion of BRCMF_FW_NVRAM_DEF(), which
should work with line numbers as well. And I can't reproduce it with
today's linux-next. If there is some issue with code not yet in
linux-next, it needs to be worked around, because older GCCs did not
have __COUNTER__.

Michal

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Kbuild: provide a __UNIQUE_ID for clang Arnd Bergmann <arnd@arndb.de> - 2016-02-08 15:40 +0100
  Re: [PATCH] Kbuild: provide a __UNIQUE_ID for clang Michal Marek <mmarek@suse.cz> - 2016-02-08 19:20 +0100

csiph-web