Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq
Date	2016-02-08 18:00 +0100
Message-ID	<qZXkm-7Uw-9@gated-at.bofh.it> (permalink)
References	<qZclr-bk-1@gated-at.bofh.it> <qZclt-bk-41@gated-at.bofh.it> <qZVsd-6HZ-3@gated-at.bofh.it> <qZXkm-7Uw-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Feb 08, 2016 at 10:08:28PM +0530, Laxman Dewangan wrote:
> On Monday 08 February 2016 08:25 PM, Mark Brown wrote:
> >On Sat, Feb 06, 2016 at 08:07:22PM +0530, Laxman Dewangan wrote:

> >>Before removing irq domains, it is require to unmap all
> >>mapped interrupt from that domain. Currently there is API
> >>to map the interrupt on chip as regmap_irq_get_virq() for
> >>creating mapping. Add equivalent API to dispose the mapped
> >>irq in irq domains.

> >This makes no sense to me.  Why would you ever want to unmap the
> >interrupts separately to destroying the domain

> This is the requirement from irq_domain_remove(). This is what we have in
> irq_domain_remove():
> kernel/irq/irqdomain.c

> I am adding the API equivalent to regmap_irq_get_virq() to unmap virtual irq
> here.

This does not explain why anyone would ever want to use this interface
(which was my question), why would anyone ever want to do this as a
separate step?

> >and why would you ever
> >want to destroy the domain without unmapping the interrupts?

> That's exactlly we are trying to do, unmap interrupt in client level before
> destroying domain.

Again, why would any client ever want to skip this step?

Thread

[PATCH V4 0/6] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-06 15:50 +0100
  [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-06 15:50 +0100
    Re: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap,  irq chip locally Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-08 11:40 +0100
      Re: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap,  irq chip locally Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-02-08 11:50 +0100
  [PATCH V4 4/6] rtc: max77686: avoid reference of parent device info multiple places Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-06 15:50 +0100
  [PATCH V4 5/6] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-06 15:50 +0100
  [PATCH V4 3/6] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-06 15:50 +0100
  [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-06 15:50 +0100
    Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq Mark Brown <broonie@kernel.org> - 2016-02-08 16:00 +0100
      Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq Mark Brown <broonie@kernel.org> - 2016-02-08 18:00 +0100
        Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-08 18:10 +0100
          Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq Mark Brown <broonie@kernel.org> - 2016-02-08 19:20 +0100
            Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-09 06:30 +0100
              Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-09 10:30 +0100
      Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-08 18:00 +0100
  [PATCH V4 2/6] rtc: max77686: fix checkpatch error Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-06 16:00 +0100

csiph-web