Re: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do
Date	Mon, 08 Feb 2016 17:50:01 +0100
Message-ID	<qZXaF-7Ql-7@gated-at.bofh.it> (permalink)
References	<qYeSm-jz-11@gated-at.bofh.it> <qYeSn-jz-35@gated-at.bofh.it> <qZVLA-74r-9@gated-at.bofh.it> <qZVVh-782-41@gated-at.bofh.it> <qZX11-7Mz-49@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=ds2+XADmIF5PmF9xEMujp2UulGmJ1EDo4nlow1SkinI=; b=cLwuUWojy40bszl+JOFPDwAZzhGgGOj36HjYZ7UN07NNyzYkyNyujygbbV1aCIWaMx wlbAfb1NAbbPm4nL8sGuhhzzv7mUu30bxEnAl94I2lNJS0vRI2bWvin1gH95/++vexCP 3q+gZh8ON3bNoNBBe7pvpfTuqpzE37XSFMhfLwnGCRdhbMSfpMYj7MOXjDsSaNlpYUZN FXrAP6EmkF/rYuBEEAY0aQz3O9LdfGjCVukvzL5g7b6VJhNmarYU5rn+4TG56U2RcFgs Wa4mflXqYyPk+bdQ5KipyINPL2uMUX66XdaFePMcWFPYL2oNkSs2TFQe7RpPWZNboYQ5 iwcA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=ds2+XADmIF5PmF9xEMujp2UulGmJ1EDo4nlow1SkinI=; b=PPxAwFOHxGNYRb107ojuJA07NNL9HKqeyLQLwLJNajlgMjvLmPMyrrP+ovYtoxsYGz 2fDon3q2fpiBH4nK885Hvv0IwPlc8qg+pEV+G+LpJn5BhsFEadIs/3kdGbiu2R6Vtosx 1l66/I9gGKGENwqMMMfEf3g47SLj61ay/qxQYNvI5Otxg8AX4FNKWqAm4nMod7EOys4i Nhz0SVATWUhpfzK2jsujiS/3nTTMphm/lEN3i0wPU3hQOXDxr1aCzf8wh1clGP5UU508 tdfg+ujxFMSdtSTo19ercYVIBn1bG+u//6RmYcSLbAMHR3BKtsDvkZ+eIdQQLa3foG4H zYAQ==
X-Gm-Message-State	AG10YOQiVbtevTaQPLoCJlGsbAizxFCtoaBEwMjeqFThAhK9G/fXiVrJXQ6vH54hd+fsrg==
X-Received	by 10.28.142.8 with SMTP id q8mr51018543wmd.47.1454949661043; Mon, 08 Feb 2016 08:41:01 -0800 (PST)
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	namit@cs.technion.ac.il
X-Original-Date	Mon, 8 Feb 2016 17:40:58 +0100
X-Original-Message-ID	<56B8C51A.2070505@redhat.com>
X-Original-References	<1454539876-8310-1-git-send-email-brogers@suse.com> <1454539876-8310-2-git-send-email-brogers@suse.com> <56B8B057.5050900@redhat.com> <56B8B29C.8060600@web.de> <56B860E202000048001251D8@prv-mh.provo.novell.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1329299

Show key headers only | View raw

On 08/02/2016 17:33, Bruce Rogers wrote:
>>> >> 
>>> >> KVM_MP_STATE_INIT_RECEIVED is what Intel calls the "wait for SIPI"
>>> >> state.  The BSP never gets a SIPI, it goes straight to 0xFFFFFFF0
>>> >> instead.  Can you explain the problem more in detail?
>> > 
>> > I suspect this is about sending INIT-SIPI from another CPU, directed to
>> > the BSP, isn't it? We may have to differentiate between CPU (including
>> > system) reset and that IPI case.
> That is correct. In looking over the KVM code which deals with BSP, this was
> the only place which seemed wrong to me wrt special casing for BSP outside the
> context of initial system initialization / reset. As far as I understand the
> BSP shouldn't be treated differently in this case.

See 8.4.2 of the SDM:

If the MP protocol has completed and a BSP is chosen, subsequent INITs
(either to a specific processor or system wide) do not cause the MP
protocol to be repeated. Instead, each logical processor examines its
BSP flag (in the IA32_APIC_BASE MSR) to determine whether it should
execute the BIOS boot-strap code (if it is the BSP) or enter a
wait-for-SIPI state (if it is an AP).

So it is correct to treat the BSP differently here, I think.

Paolo

Thread

[PATCH 1/2] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset Bruce Rogers <brogers@suse.com> - 2016-02-04 00:20 +0100
  [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do Bruce Rogers <brogers@suse.com> - 2016-02-04 00:20 +0100
    Re: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do Paolo Bonzini <pbonzini@redhat.com> - 2016-02-08 16:20 +0100
      Re: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do Jan Kiszka <jan.kiszka@web.de> - 2016-02-08 16:30 +0100
        Re: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like  APs do "Bruce Rogers" <brogers@suse.com> - 2016-02-08 17:40 +0100
          Re: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do Paolo Bonzini <pbonzini@redhat.com> - 2016-02-08 17:50 +0100
            Re: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like  APs do "Bruce Rogers" <brogers@suse.com> - 2016-02-08 18:30 +0100
              Re: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do Paolo Bonzini <pbonzini@redhat.com> - 2016-02-08 18:50 +0100
            Re: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like  APs do "Bruce Rogers" <brogers@suse.com> - 2016-02-08 18:40 +0100
              Re: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do Jan Kiszka <jan.kiszka@web.de> - 2016-02-08 19:00 +0100
  Re: [PATCH 1/2] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset Nadav Amit <nadav.amit@gmail.com> - 2016-02-04 00:20 +0100
    Re: [PATCH 1/2] KVM: x86: fix ordering of cr0 initialization  code in vmx_cpu_reset "Bruce Rogers" <brogers@suse.com> - 2016-02-04 00:40 +0100
  Re: [PATCH 1/2] KVM: x86: fix ordering of cr0 initialization code in  vmx_cpu_reset Paolo Bonzini <pbonzini@redhat.com> - 2016-02-08 16:10 +0100
    Re: [PATCH 1/2] KVM: x86: fix ordering of cr0 initialization  code in vmx_cpu_reset "Bruce Rogers" <brogers@suse.com> - 2016-02-08 17:30 +0100
      Re: [PATCH 1/2] KVM: x86: fix ordering of cr0 initialization code in  vmx_cpu_reset Paolo Bonzini <pbonzini@redhat.com> - 2016-02-08 17:50 +0100

csiph-web