Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329285

Re: [PATCH V3 01/13] cpufreq: governor: Create generic macro for global tuners

Show all headers | View raw

On Mon, Feb 8, 2016 at 12:39 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> Some tunables are present in governor specific structures, whereas one
> (min_sampling_rate) is present in global 'struct dbs_data'.

To me, the word "global" is not the best one to express that.
"Common" would probably be better.  Or "generic" or similar.

It's just that these tunables apply to both governors (or "all"
governors if you will) as opposed to some other ones specific to a
particular governor type.

So I'd suggest replacing "global" with "common" in the patch in the
names of the macros too.

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V3 00/13] cpufreq: governors: Fix ABBA lockups Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 12:50 +0100
  [PATCH V3 07/13] cpufreq: Call __cpufreq_governor() with policy->rwsem held Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 12:50 +0100
  [PATCH V3 02/13] cpufreq: governor: Move common tunables to 'struct dbs_data' Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 12:50 +0100
  [PATCH V3 05/13] Revert "cpufreq: Drop rwsem lock around CPUFREQ_GOV_POLICY_EXIT" Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 12:50 +0100
  [PATCH V3 13/13] cpufreq: conservative: Update sample_delay_ns immediately Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 12:50 +0100
  [PATCH V3 10/13] cpufreq: governor: No need to manage state machine now Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 12:50 +0100
  [PATCH V3 04/13] cpufreq: governor: Drop unused macros for creating governor tunable attributes Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 12:50 +0100
  [PATCH V3 09/13] cpufreq: governor: Move common sysfs tunables to cpufreq_governor.c Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 12:50 +0100
    Re: [PATCH V3 09/13] cpufreq: governor: Move common sysfs tunables to cpufreq_governor.c "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-08 14:00 +0100
      Re: [PATCH V3 09/13] cpufreq: governor: Move common sysfs tunables  to cpufreq_governor.c Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 14:10 +0100
        Re: [PATCH V3 09/13] cpufreq: governor: Move common sysfs tunables to cpufreq_governor.c "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-08 14:30 +0100
  [PATCH V3 01/13] cpufreq: governor: Create generic macro for global tuners Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 12:50 +0100
    Re: [PATCH V3 01/13] cpufreq: governor: Create generic macro for  global tuners "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-08 17:40 +0100
  Re: [PATCH V3 00/13] cpufreq: governors: Fix ABBA lockups Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-02-08 14:00 +0100
    Re: [PATCH V3 00/13] cpufreq: governors: Fix ABBA lockups Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 14:00 +0100
      Re: [PATCH V3 00/13] cpufreq: governors: Fix ABBA lockups Juri Lelli <juri.lelli@arm.com> - 2016-02-08 17:40 +0100
        Re: [PATCH V3 00/13] cpufreq: governors: Fix ABBA lockups Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-08 18:00 +0100
  Re: [PATCH V3 00/13] cpufreq: governors: Fix ABBA lockups "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-08 22:50 +0100

csiph-web