Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1329236

Re: [PATCH 5/5] drivers/pci: make most of the PCI_DW drivers modular

From Paul Gortmaker <paul.gortmaker@windriver.com>
Newsgroups linux.kernel
Subject Re: [PATCH 5/5] drivers/pci: make most of the PCI_DW drivers modular
Date 2016-02-08 17:00 +0100
Message-ID <qZWok-7it-55@gated-at.bofh.it> (permalink)
References <qZHyW-5BD-5@gated-at.bofh.it> <qZHyW-5BD-7@gated-at.bofh.it> <qZQVA-3NI-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Re: [PATCH 5/5] drivers/pci: make most of the PCI_DW drivers modular] On 08/02/2016 (Mon 11:00) Arnd Bergmann wrote:

> On Sunday 07 February 2016 19:00:44 Paul Gortmaker wrote:
> > We've exported the symbols that we know these specific drivers
> > will need as tristate, so now we can make the conversion from
> > bool to tristate w/o concern for build regressions.
> > 
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Ley Foon Tan <lftan@altera.com>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: linux-pci@vger.kernel.org
> > Cc: linux-arm-msm@vger.kernel.org
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> Looks good, but I'm not sure what happens on unload. Did you check?

Per the 0/N I've not got the capability to do run time testing for any
of this stuff.  And from previous discussions, ISTR that people didn't
want to see a blanket block-unload policy implemented.

> Until this is tested, maybe it's best to prevent module unloading?

If that is what people want, I can add that.

P.
-- 

> 
> 	Arnd

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 5/5] drivers/pci: make most of the PCI_DW drivers modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-08 01:10 +0100
  Re: [PATCH 5/5] drivers/pci: make most of the PCI_DW drivers modular Arnd Bergmann <arnd@arndb.de> - 2016-02-08 11:10 +0100
    Re: [PATCH 5/5] drivers/pci: make most of the PCI_DW drivers modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-08 17:00 +0100

csiph-web