Re: [PATCH] net: am79c961a: avoid %? in inline assembly

From	Russell King - ARM Linux <linux@arm.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: am79c961a: avoid %? in inline assembly
Date	2016-02-08 16:50 +0100
Message-ID	<qZWeB-7eV-1@gated-at.bofh.it> (permalink)
References	<qZV8S-6zW-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 08, 2016 at 03:33:42PM +0100, Arnd Bergmann wrote:
> The am79c961a.c driver fails to build with clang because of an
> unusual inline assembly construct:
> 
> drivers/net/ethernet/amd/am79c961a.c:53:7: error: invalid % escape in inline assembly string
>  "str%?h        %1, [%2]        @ NET_RAP\n\t"
> 
> The same change has been done a decade ago in arch/arm as of
> 6a39dd6222dd ("[ARM] 3759/2: Remove uses of %?"), but apparently
> some drivers were missed.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

Thanks Arnd.

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: am79c961a: avoid %? in inline assembly Arnd Bergmann <arnd@arndb.de> - 2016-02-08 15:40 +0100
  Re: [PATCH] net: am79c961a: avoid %? in inline assembly Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-08 16:50 +0100

csiph-web