Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329252

Re: [PATCH] reset: lpc18xx: Make reset_control_ops const

Show all headers | View raw

Hi Philipp,

On 8 February 2016 at 14:28, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> The lpc18xx_rgu_ops structure is never modified. Make it const.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  drivers/reset/reset-lpc18xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-lpc18xx.c b/drivers/reset/reset-lpc18xx.c
> index 70922e9..3b8a4f5 100644
> --- a/drivers/reset/reset-lpc18xx.c
> +++ b/drivers/reset/reset-lpc18xx.c
> @@ -136,7 +136,7 @@ static int lpc18xx_rgu_status(struct reset_controller_dev *rcdev,
>         return !(readl(rc->base + offset) & bit);
>  }
>
> -static struct reset_control_ops lpc18xx_rgu_ops = {
> +static const struct reset_control_ops lpc18xx_rgu_ops = {
>         .reset          = lpc18xx_rgu_reset,
>         .assert         = lpc18xx_rgu_assert,
>         .deassert       = lpc18xx_rgu_deassert,

Acked-by: Joachim Eastwood <manabian@gmail.com>


regards,
Joachim Eastwood

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] reset: lpc18xx: Make reset_control_ops const Philipp Zabel <p.zabel@pengutronix.de> - 2016-02-08 14:30 +0100
  Re: [PATCH] reset: lpc18xx: Make reset_control_ops const Joachim Eastwood <manabian@gmail.com> - 2016-02-08 17:20 +0100
  Re: [PATCH] reset: lpc18xx: Make reset_control_ops const kbuild test robot <lkp@intel.com> - 2016-02-08 21:30 +0100

csiph-web