Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329099

Re: [PATCH v2] mmc: pxamci: fix the device-tree probe deferral path

Show all headers | View raw

Ulf Hansson <ulf.hansson@linaro.org> writes:

> On 6 February 2016 at 22:14, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>> When the gpio driver is probed after the mmc one, the read/write gpio
>> and card detection one return -EPROBE_DEFER. Unfortunately, the memory
>> region remains requested, and upon the next probe, the probe will fail
>> anyway with -EBUSY.
>>
>> Fix this by releasing the memory resource upon probe failure.
>>
>> More broadly, this patch uses devm_*() primitives whenever possible in
>> the probe function.
>
> There's actually also clocks and regulators that may be converted to
> use the devm* functions.
> Do you want to do that as a part of this patch as well? Otherwise I
> can apply as is.
Yes, I will add the regulator and clock in this patch, you're right, this makes
sense to me, v3 on its way.

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] mmc: pxamci: fix the device-tree probe deferral path Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-06 22:20 +0100
  Re: [PATCH v2] mmc: pxamci: fix the device-tree probe deferral path Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-08 10:20 +0100
    Re: [PATCH v2] mmc: pxamci: fix the device-tree probe deferral path Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-08 15:20 +0100

csiph-web