Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328993

Re: [PATCH v3 4/6] arm64: Enable dynamic CPU capacity initialization

Show all headers | View raw

On 03/02/16 11:59, Juri Lelli wrote:
> Define arch_wants_init_cpu_capacity() to return true; so that
> cpufreq_init_cpu_capacity() can go ahead and profile CPU capacities
> at boot time.

[...]

>  
> +bool arch_wants_init_cpu_capacity(void)
> +{
> +	return true;

Isn't this a little bit too simple? Not every ARM/ARM64 platform is a
heterogeneous one.

You could add code to compare the cpu node 'compatible' properties
(required) and only return true if they differ, which would let you
detect uarch based heterogeneity.

In case of max. frequency based heterogeneity (clusters consisting of
same cpu types but running at different max. frequency), you're at the
mercy of cpu node 'clock-frequency' properties (optional).
We might argue that for these platforms, providing cpu node
'clock-frequency' properties is necessary.
The 'struct cpu_efficiency table_efficiency[]' based approach in ARM
already faces this problem.

> +}
> +
>  static int __init get_cpu_for_node(struct device_node *node)
>  {
>  	struct device_node *cpu_node;
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/6] CPUs capacity information for heterogeneous systems Juri Lelli <juri.lelli@arm.com> - 2016-02-03 13:00 +0100
  [PATCH v3 4/6] arm64: Enable dynamic CPU capacity initialization Juri Lelli <juri.lelli@arm.com> - 2016-02-03 13:00 +0100
    Re: [PATCH v3 4/6] arm64: Enable dynamic CPU capacity initialization Dietmar Eggemann <dietmar.eggemann@arm.com> - 2016-02-08 13:30 +0100
      Re: [PATCH v3 4/6] arm64: Enable dynamic CPU capacity initialization Mark Brown <broonie@kernel.org> - 2016-02-08 14:20 +0100
        Re: [PATCH v3 4/6] arm64: Enable dynamic CPU capacity initialization Dietmar Eggemann <dietmar.eggemann@arm.com> - 2016-02-08 14:50 +0100
  [PATCH v3 6/6] arm64: add sysfs cpu_capacity attribute Juri Lelli <juri.lelli@arm.com> - 2016-02-03 13:10 +0100
    Re: [PATCH v3 6/6] arm64: add sysfs cpu_capacity attribute Dietmar Eggemann <dietmar.eggemann@arm.com> - 2016-02-05 18:20 +0100
      Re: [PATCH v3 6/6] arm64: add sysfs cpu_capacity attribute Juri Lelli <juri.lelli@arm.com> - 2016-02-05 18:50 +0100
  [PATCH v3 5/6] arm: add sysfs cpu_capacity attribute Juri Lelli <juri.lelli@arm.com> - 2016-02-03 13:10 +0100
  [PATCH v3 3/6] arm: Enable dynamic CPU capacity initialization Juri Lelli <juri.lelli@arm.com> - 2016-02-03 13:10 +0100
  Re: [PATCH v3 0/6] CPUs capacity information for heterogeneous  systems Steve Muckle <steve.muckle@linaro.org> - 2016-02-09 01:10 +0100

csiph-web