Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328894

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote:
> On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote:
> > >> +static int ads1015_read_raw(struct iio_dev *indio_dev,
> > >> +                         struct iio_chan_spec const *chan, int *val,
> > >> +                         int *val2, long mask)
> > >> +{
> > >> +     int ret, idx;
> > >> +     struct ads1015_data *data = iio_priv(indio_dev);
> > >> +
> > >> +     mutex_lock(&data->lock);
> > >> +     switch (mask) {
> > >> +     case IIO_CHAN_INFO_RAW:
> > >> +             if (iio_buffer_enabled(indio_dev)) {
> > >> +                     ret = -EBUSY;
> > >> +                     break;
> > >> +             }
> > >> +
> > >> +             ret = ads1015_set_power_state(data, true);
> > >> +             if (ret < 0)
> > >> +                     break;
> > >
> > > Just tested the driver on a Dragonboard 410C with a robotics mezzanine that I
> > > designed.
> > >
> > > The above ads1015_set_power_state(data, true) is always returning -EINVAL.
> > >
> > > Any ideas why that would be happening?
> > > I think it may be the return from pm_runtime_get_sync?
> > 
> > Can you confirm that pm_runtime_get_sync fails? Using some printk?
> > 
> > Also adding printks in suspend/resume function would be helpful. Do
> > you have CONFIG_PM enabled?
> >
> 
> Indeed it is the pm_runtime_get_sync that fails with a -EINVAL.
> 
> > >
> > > When I comment out the break the readings come back but are not updated continually.
> > > If I read in_voltage0-voltage1_raw then in_voltage0_raw the value is updated.
> > 
> > I guess this is normal if set_power_state fails.
> 
> The hwmod driver works fine BTW.
> 
> My guess is there is an issue with the qup i2c driver seeing as it has worked on
> other system without issue.
> 
> CC'd some the latest developer on the qup i2c driver.
> 
> I2C guys have any ideas on this?
> 

Adding some more people who recently worked on this. Might be nice to
know which kernel version you are using.

> > 
> > thanks,
> > Daniel.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta <daniel.baluta@intel.com> - 2016-02-05 14:20 +0100
  Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Michael Welling <mwelling@ieee.org> - 2016-02-05 18:30 +0100
    Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta <daniel.baluta@intel.com> - 2016-02-05 20:40 +0100
      Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Michael Welling <mwelling@ieee.org> - 2016-02-05 21:00 +0100
      Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Michael Welling <mwelling@ieee.org> - 2016-02-06 01:40 +0100
        Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Wolfram Sang <wsa@the-dreams.de> - 2016-02-08 11:30 +0100
          Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta <daniel.baluta@intel.com> - 2016-02-08 15:50 +0100
            Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta <daniel.baluta@intel.com> - 2016-02-08 16:10 +0100
            Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Michael Welling <mwelling@ieee.org> - 2016-02-08 17:40 +0100
          Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Michael Welling <mwelling@ieee.org> - 2016-02-08 17:40 +0100
            RE: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support "Sricharan" <sricharan@codeaurora.org> - 2016-02-08 20:20 +0100
              Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Michael Welling <mwelling@ieee.org> - 2016-02-08 20:20 +0100
                Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Wolfram Sang <wsa@the-dreams.de> - 2016-02-08 21:10 +0100
                Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Michael Welling <mwelling@ieee.org> - 2016-02-08 21:10 +0100
  Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Lucas De Marchi <lucas.de.marchi@gmail.com> - 2016-02-05 22:20 +0100
    Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta <daniel.baluta@intel.com> - 2016-02-05 22:50 +0100
      Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Jonathan Cameron <jic23@kernel.org> - 2016-02-06 12:00 +0100
  Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Jonathan Cameron <jic23@kernel.org> - 2016-02-06 12:10 +0100
  Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Jonathan Cameron <jic23@kernel.org> - 2016-02-06 12:10 +0100

csiph-web