Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1328874

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

From Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller
Date 2016-02-08 11:00 +0100
Message-ID <qZQLV-3tN-29@gated-at.bofh.it> (permalink)
References <qZQ9b-3eh-3@gated-at.bofh.it> <qZQ9d-3eh-39@gated-at.bofh.it> <qZQCe-3pM-3@gated-at.bofh.it>
Organization Free Electrons

Show all headers | View raw


Hello Marc,

On Mon, 8 Feb 2016 09:44:49 +0000, Marc Zyngier wrote:

> > +static struct msi_domain_info alpine_msix_domain_info = {
> > +	.flags	= MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
> > +		  MSI_FLAG_PCI_MSIX,
> 
> You can probably add MSI_FLAG_PCI_MSI, it should work as well (MULTI_MSI
> obviously won't).

Why wouldn't MULTI_MSI work? The code is using
bitmap_find_next_zero_area() in alpine_msix_allocate_sgi() precisely to
find num_req consecutive bits set to 0, in order to allocate multiple
MSIs at once. Am I missing something?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] irqchip: introduce the Alpine MSIX driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-02-08 10:20 +0100
  [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-02-08 10:20 +0100
    Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-02-08 10:50 +0100
      Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-08 11:00 +0100
        Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-02-08 11:10 +0100
      Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-02-08 11:30 +0100
        Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-02-08 11:40 +0100
          Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-02-08 11:50 +0100
            Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-02-08 12:00 +0100
              Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-02-08 12:10 +0100
      Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-02-08 15:10 +0100
        Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-02-08 15:20 +0100
    Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Thomas Gleixner <tglx@linutronix.de> - 2016-02-08 11:40 +0100
      Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-02-08 15:20 +0100
        Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-02-08 15:30 +0100
          Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-02-08 15:50 +0100
            Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-02-08 16:10 +0100
  [PATCH 4/6] ARM: dts: alpine: add the MSIX node Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-02-08 10:20 +0100

csiph-web