Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328868

Re: [PATCH 3/5] drivers/pci: export dw syms enabling board specific PCI code to be tristate

Show all headers | View raw

On Sunday 07 February 2016 19:00:42 Paul Gortmaker wrote:
> After converting the drivers who select PCI_DW from bool to tristate,
> the following symbols need to be exported, simply based on the output
> from modpost failures.
> 
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Cc: Pratyush Anand <pratyush.anand@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 

Looks good in principle, but maybe use EXPORT_SYMBOL_GPL? These
are just meant to be used internally by the drivers after all.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] drivers/pci: export dw syms enabling board specific PCI code to be tristate Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-08 01:10 +0100
  Re: [PATCH 3/5] drivers/pci: export dw syms enabling board specific PCI code to be tristate Arnd Bergmann <arnd@arndb.de> - 2016-02-08 11:00 +0100
    Re: [PATCH 3/5] drivers/pci: export dw syms enabling board specific  PCI code to be tristate Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-08 17:00 +0100

csiph-web