Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328823

Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch

Show all headers | View raw

On Sun, Feb 7, 2016 at 10:13 PM, Andreas Färber <afaerber@suse.de> wrote:
> As preparation for arm64 based mesongxbb, which pulls in this code once
> enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch.
> The loop uses a local unsigned int variable, so adopt that type,
> matching the header.
>
> Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller")
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  drivers/clk/meson/clkc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/clkc.c b/drivers/clk/meson/clkc.c
> index c83ae1367abc..d920d410b51d 100644
> --- a/drivers/clk/meson/clkc.c
> +++ b/drivers/clk/meson/clkc.c
> @@ -198,7 +198,7 @@ meson_clk_register_fixed_rate(const struct clk_conf *clk_conf,
>  }
>
>  void __init meson_clk_register_clks(const struct clk_conf *clk_confs,
> -                                   size_t nr_confs,
> +                                   unsigned int nr_confs,
>                                     void __iomem *clk_base)
>  {
>         unsigned int i;

Nit: I'd prefer to fix declaration in drivers/clk/meson/clkc.h with
size_t since we are going to use it for array indexing.

Also please, CC linux-meson@googlegroups.com on meson related patches.

Thanks!

-- 
Carlo Caione

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch Andreas Färber <afaerber@suse.de> - 2016-02-07 22:20 +0100
  Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch Carlo Caione <carlo@caione.org> - 2016-02-08 09:40 +0100
    Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch Carlo Caione <carlo@caione.org> - 2016-02-08 10:00 +0100
    Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type  mismatch Andreas Färber <afaerber@suse.de> - 2016-02-08 12:00 +0100
  Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type  mismatch Stephen Boyd <sboyd@codeaurora.org> - 2016-02-08 23:20 +0100
    Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type  mismatch Andreas Färber <afaerber@suse.de> - 2016-02-08 23:30 +0100

csiph-web