Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1328798

[PATCH 1/2] Staging:iio:Prefer using BIT macro

From Bhumika Goyal <bhumirks@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/2] Staging:iio:Prefer using BIT macro
Date 2016-02-08 08:00 +0100
Message-ID <qZNXI-1zU-1@gated-at.bofh.it> (permalink)
References <qZNXI-1zU-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
 @@ int g; @@
-(1 << g)
+BIT(g)

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/staging/iio/adc/ad7816.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
index 2226051..f631012 100644
--- a/drivers/staging/iio/adc/ad7816.c
+++ b/drivers/staging/iio/adc/ad7816.c
@@ -222,7 +222,7 @@ static ssize_t ad7816_show_value(struct device *dev,
 		value = (s8)((data >> AD7816_TEMP_FLOAT_OFFSET) - 103);
 		data &= AD7816_TEMP_FLOAT_MASK;
 		if (value < 0)
-			data = (1 << AD7816_TEMP_FLOAT_OFFSET) - data;
+			data = BIT(AD7816_TEMP_FLOAT_OFFSET) - data;
 		return sprintf(buf, "%d.%.2d\n", value, data * 25);
 	}
 	return sprintf(buf, "%u\n", data);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] Staging:iio:Prefer using BIT macro Bhumika Goyal <bhumirks@gmail.com> - 2016-02-08 08:00 +0100
  Re: [PATCH 1/2] Staging:iio:Prefer using BIT macro Lars-Peter Clausen <lars@metafoo.de> - 2016-02-08 10:20 +0100
    Re: [PATCH 1/2] Staging:iio:Prefer using BIT macro Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-08 16:20 +0100

csiph-web