Re: [PATCH] staging: sm750fb: Fix comments style

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: sm750fb: Fix comments style
Date	2016-02-08 04:00 +0100
Message-ID	<qZKds-77A-11@gated-at.bofh.it> (permalink)
References	<qZKds-77A-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 02, 2015 at 08:18:11PM +0100, sebastian.lawniczak@yahoo.com wrote:
> From: Sebastian Lawniczak <sebastian.lawniczak@yahoo.com>
> 
> Fix warnings reported by checkpatch.pl in block comments.
> 
> Signed-off-by: Sebastian Lawniczak <sebastian.lawniczak@yahoo.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 70 +++++++++++++++++++----------------
>  1 file changed, 39 insertions(+), 31 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 0331d34..01ddf44 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -86,8 +86,10 @@ static void setMemoryClock(unsigned int frequency)
>  		return;
>  
>  	if (frequency) {
> -		/* Set the frequency to the maximum frequency that the DDR Memory can take
> -		which is 336MHz. */
> +		/*
> +		* Set the frequency to the maximum frequency that the DDR Memory can take
> +		* which is 336MHz.
> +		*/

It should look like:
		/*
		 * Set the frequency to the maximum frequency that the DDR Memory can take
		 * which is 336MHz.
		 */

So I can't take this patch, sorry.

Please fix it up and resend.

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: sm750fb: Fix comments style Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-08 04:00 +0100

csiph-web