Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328645

Re: [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak

Show all headers | View raw

On Fri, Jan 29, 2016 at 10:07:32PM -0800, John Stultz wrote:
> From: San Mehat <san@google.com>
> 
> As it turns out, the CONFIG_PROFILING interfaces leak a
> task struct if the notifier chain returns NOTIFY_OK.. doh.
> 
> This patch reworks lowmemkiller to use the new generic task
> free notifier chain.
> 
> Cc: Android Kernel Team <kernel-team@android.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Signed-off-by: San Mehat <san@google.com>
> [jstultz: Commit subject tweak]
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
>  drivers/staging/android/lowmemorykiller.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
> index 8b5a4a8..806643d 100644
> --- a/drivers/staging/android/lowmemorykiller.c
> +++ b/drivers/staging/android/lowmemorykiller.c
> @@ -40,7 +40,6 @@
>  #include <linux/sched.h>
>  #include <linux/swap.h>
>  #include <linux/rcupdate.h>
> -#include <linux/profile.h>
>  #include <linux/notifier.h>
>  
>  static u32 lowmem_debug_level = 1;
> -- 
> 1.9.1

The changelog comment seems a bit "odd" when looking at the patch here.
Is the patch really correct?  The changelog?

totally confused,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] staging: Updates from the Android tree John Stultz <john.stultz@linaro.org> - 2016-01-30 07:10 +0100
  [PATCH 7/9] staging: ion: Handle the memory mapping correctly on x86 John Stultz <john.stultz@linaro.org> - 2016-01-30 07:10 +0100
  [PATCH 2/9] staging: ashmem: Add missing include John Stultz <john.stultz@linaro.org> - 2016-01-30 07:10 +0100
  [PATCH 9/9] staging: ion: Fix page pool cache policy John Stultz <john.stultz@linaro.org> - 2016-01-30 07:10 +0100
  [PATCH 8/9] staging: ion: Add X86 dependency for ION_POOL_CACHE_POLICY John Stultz <john.stultz@linaro.org> - 2016-01-30 07:10 +0100
  [PATCH 1/9] staging: ashmem: Avoid deadlock with mmap/shrink John Stultz <john.stultz@linaro.org> - 2016-01-30 07:10 +0100
  [PATCH 4/9] staging: lowmemorykiller: Make default lowmemorykiller debug message useful John Stultz <john.stultz@linaro.org> - 2016-01-30 07:20 +0100
  [PATCH 5/9] staging: lowmemorykiller: Trace kill events. John Stultz <john.stultz@linaro.org> - 2016-01-30 07:20 +0100
  [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak John Stultz <john.stultz@linaro.org> - 2016-01-30 07:20 +0100
    Re: [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak Greg KH <gregkh@linuxfoundation.org> - 2016-02-07 23:50 +0100
      Re: [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak John Stultz <john.stultz@linaro.org> - 2016-02-08 20:00 +0100
  [PATCH 6/9] staging: ion: Set minimum carveout heap allocation order to PAGE_SHIFT John Stultz <john.stultz@linaro.org> - 2016-01-30 07:20 +0100
    Re: [PATCH 6/9] staging: ion: Set minimum carveout heap allocation  order to PAGE_SHIFT Laura Abbott <labbott@redhat.com> - 2016-02-01 21:30 +0100
  Re: [PATCH 0/9] staging: Updates from the Android tree Laura Abbott <labbott@redhat.com> - 2016-02-01 22:20 +0100
    Re: [PATCH 0/9] staging: Updates from the Android tree John Stultz <john.stultz@linaro.org> - 2016-02-01 22:30 +0100
  Re: [PATCH 0/9] staging: Updates from the Android tree Greg KH <gregkh@linuxfoundation.org> - 2016-02-08 00:00 +0100

csiph-web