Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328638

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

Show all headers | View raw

On 02/07/2016 09:04 AM, James Bottomley wrote:
> On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote:
>> Keith said it should be on by default, and I promised him to change
>> it once we run into problems, which I guess this counts as.
>>
>> But just curious:  what distro are you using?  Upstream systemd
>> explicitly rejected using scsi_id for NVMe here:
>>
>> 	https://github.com/systemd/systemd/issues/1453
>>
>> and all my test systems don't do this either.
>
> This was SUSE (in my case, openSUSE Leap).  I just checked the source
> package; they patch the by-id rules back in for NVME:
>
> # PATCH-FIX-SUSE 1101-rules-persistent-device-names-for-NVMe-devices.patch (bsc#944132)
> Patch1101:      1101-rules-persistent-device-names-for-NVMe-devices.patch
>
> The bugzilla is giving access denied for bug id 944132, so it's likely
> some proprietary vendor problem.  The patch has no preamble, so it's
> hard to tell what they were thinking.

I run root-on-nvme on my laptop, and I haven't observed any problems. 
Generally I hate for options to default y unless absolutely necessary, 
it's a sure fire way to feature creep your kernel without noticing. I 
don't think getting all hot about this issue is fair, if the only known 
case is suse.

If anything, let's make the description better. It's trying to be funny, 
it'd be better if it was descriptive and covered this case as well.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support  optional James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-02-06 19:40 +0100
  Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional Christoph Hellwig <hch@lst.de> - 2016-02-07 10:30 +0100
    Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-02-07 17:10 +0100
      Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional Jens Axboe <axboe@kernel.dk> - 2016-02-07 23:30 +0100
        Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-02-08 00:10 +0100
          Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional Christoph Hellwig <hch@lst.de> - 2016-02-08 08:30 +0100
          Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional Hannes Reinecke <hare@suse.de> - 2016-02-08 08:40 +0100
            Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional Sagi Grimberg <sagig@dev.mellanox.co.il> - 2016-02-08 11:10 +0100
              Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional Christoph Hellwig <hch@lst.de> - 2016-02-08 11:20 +0100
                Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional Hannes Reinecke <hare@suse.de> - 2016-02-08 16:20 +0100
                Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional Keith Busch <keith.busch@intel.com> - 2016-02-08 17:20 +0100
                Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional Keith Busch <keith.busch@intel.com> - 2016-02-08 16:20 +0100
            Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-02-08 16:30 +0100
      Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO  support optional Hannes Reinecke <hare@suse.de> - 2016-02-08 08:30 +0100

csiph-web