Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1328190

Re: [PATCH] devm_memremap: Fix error value when memremap failed

From Dan Williams <dan.j.williams@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] devm_memremap: Fix error value when memremap failed
Date 2016-02-06 03:00 +0100
Message-ID <qZ0ki-ev-5@gated-at.bofh.it> (permalink)
References <qYZex-7Oq-1@gated-at.bofh.it> <qZ0ki-ev-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Feb 5, 2016 at 5:49 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Fri, Feb 5, 2016 at 5:40 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
>> devm_memremap() returns an ERR_PTR() value in case of error.
>> However, it returns NULL when memremap() failed.  This causes
>> the caller, such as the pmem driver, to proceed and oops later.
>>
>> Change devm_memremap() to return ERR_PTR(-ENXIO) when memremap()
>> failed.
>>
>> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>
> Acked-by: Dan Williams <dan.j.williams@intel.com>

Should also go to -stable, I'll add that and include this with some
other fixes I have brewing.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] devm_memremap: Fix error value when memremap failed Toshi Kani <toshi.kani@hpe.com> - 2016-02-06 01:50 +0100
  Re: [PATCH] devm_memremap: Fix error value when memremap failed Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-02-06 02:30 +0100
  Re: [PATCH] devm_memremap: Fix error value when memremap failed Dan Williams <dan.j.williams@intel.com> - 2016-02-06 03:00 +0100
    Re: [PATCH] devm_memremap: Fix error value when memremap failed Dan Williams <dan.j.williams@intel.com> - 2016-02-06 03:00 +0100

csiph-web