Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1326980

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

From Timur Tabi <timur@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver
Date 2016-02-04 17:40 +0100
Message-ID <qYv6O-4s9-5@gated-at.bofh.it> (permalink)
References <qY9pF-4WX-3@gated-at.bofh.it> <qY9pF-4WX-1@gated-at.bofh.it> <qYv6O-4s9-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Will Deacon wrote:
>> +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd)
>> >+{
>> >+	struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd);
>> >+
>> >+	/*
>> >+	* Writing WRR for an explicit watchdog refresh.
>> >+	* You can write anyting(like 0xc0ffee).
>> >+	*/
>> >+	writel(0xc0ffee, gwdt->refresh_base + SBSA_GWDT_WRR);
>> >+
>> >+	return 0;
>> >+}
> You might get in trouble for that. 0xd09f00d is probably less poisonous.
>
> http://www.petpoisonhelpline.com/poison/caffeine/

Any reason why we can't just keep it simple and write 0?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver fu.wei@linaro.org - 2016-02-03 18:30 +0100
  Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Timur Tabi <timur@codeaurora.org> - 2016-02-03 18:50 +0100
    Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Fu Wei <fu.wei@linaro.org> - 2016-02-03 19:00 +0100
      Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Timur Tabi <timur@codeaurora.org> - 2016-02-03 19:00 +0100
        Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Fu Wei <fu.wei@linaro.org> - 2016-02-03 19:20 +0100
          Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Timur Tabi <timur@codeaurora.org> - 2016-02-03 19:20 +0100
  Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-02-04 17:30 +0100
    Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Fu Wei <fu.wei@linaro.org> - 2016-02-05 10:10 +0100
  Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Timur Tabi <timur@codeaurora.org> - 2016-02-04 17:40 +0100
    Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Guenter Roeck <linux@roeck-us.net> - 2016-02-04 17:50 +0100
      Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Fu Wei <fu.wei@linaro.org> - 2016-02-05 10:00 +0100
  Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Will Deacon <will.deacon@arm.com> - 2016-02-04 17:40 +0100

csiph-web