Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1326951

Re: linux-next: build failure after merge of the aio tree

From Russell King - ARM Linux <linux@arm.linux.org.uk>
Newsgroups linux.kernel
Subject Re: linux-next: build failure after merge of the aio tree
Date 2016-02-04 17:20 +0100
Message-ID <qYuNs-4ix-9@gated-at.bofh.it> (permalink)
References (5 earlier) <qYsLD-1hC-1@gated-at.bofh.it> <qYsVj-1nc-5@gated-at.bofh.it> <qYteG-3bN-11@gated-at.bofh.it> <qYteG-3bN-9@gated-at.bofh.it> <qYuDM-4en-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Feb 04, 2016 at 11:01:01AM -0500, Benjamin LaHaise wrote:
> On Thu, Feb 04, 2016 at 02:39:07PM +0000, Russell King - ARM Linux wrote:
> > However, this one should warn:
> > 
> > int test_wrong(char **v, const char **p)
> > { return __get_user(*v, p); }
> > 
> > Good luck (I think you'll need lots of it to get a working solution)! :)
> 
> This works with your test cases on x86-32.  Note that it's only compile + 
> link tested at present.

That's the easy bit!

The problem you're going to run into is here:

#define __get_user_nocheck(x, ptr, size)                                \
({                                                                      \
        int __gu_err;                                                   \
        unsigned long __gu_val;                                         \
        __uaccess_begin();                                              \
        __get_user_size(__gu_val, (ptr), (size), __gu_err, -EFAULT);    \
        __uaccess_end();                                                \
        (x) = (__force __typeof__(*(ptr)))__gu_val;                     \

__gu_val will be 32-bit, even when you're wanting a 64-bit quantity.
That's where the fun and games start...

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: linux-next: build failure after merge of the aio tree Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-29 12:40 +0100
  Re: linux-next: build failure after merge of the aio tree Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-29 13:10 +0100
    Re: linux-next: build failure after merge of the aio tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-02-04 03:30 +0100
      Re: linux-next: build failure after merge of the aio tree Benjamin LaHaise <bcrl@kvack.org> - 2016-02-04 14:50 +0100
        Re: linux-next: build failure after merge of the aio tree Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-04 15:00 +0100
          Re: linux-next: build failure after merge of the aio tree Benjamin LaHaise <bcrl@kvack.org> - 2016-02-04 15:10 +0100
            Re: linux-next: build failure after merge of the aio tree Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-04 15:20 +0100
              Re: linux-next: build failure after merge of the aio tree Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-04 15:40 +0100
                Re: linux-next: build failure after merge of the aio tree Benjamin LaHaise <bcrl@kvack.org> - 2016-02-04 17:10 +0100
                Re: linux-next: build failure after merge of the aio tree Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-04 17:20 +0100
                Re: linux-next: build failure after merge of the aio tree Benjamin LaHaise <bcrl@kvack.org> - 2016-02-04 17:30 +0100
                Re: linux-next: build failure after merge of the aio tree Benjamin LaHaise <bcrl@kvack.org> - 2016-02-04 17:50 +0100
                Re: linux-next: build failure after merge of the aio tree Benjamin LaHaise <bcrl@kvack.org> - 2016-02-04 19:50 +0100
              Re: linux-next: build failure after merge of the aio tree Benjamin LaHaise <bcrl@kvack.org> - 2016-02-04 15:40 +0100

csiph-web