Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1326784

Re: [PATCH 4/4] KVM: x86: remove notifiers from PIT discard policy

Show all headers | View raw

2016-02-03 17:51+0100, Paolo Bonzini:
> On 03/02/2016 17:23, Radim Krčmář wrote:
>> Discard policy doesn't rely on information from notifiers, so we don't
>> need to register notifiers unconditionally.
>> 
>> Use of ps->lock doesn't make sense, but isn't any worse than before.

Oops, it is worse than before ... toggling KVM_REINJECT_CONTROL when the
guest is running and reading reinject without locking is now far more
complex.  This patch should have also ignored KVM_REINJECT_CONTROL when
PIT has been started.

> Oh, it's perfectly okay.  Too fine-grained locks are bad, and lock
> contention on ps->lock is a non-issue.
> 
> Can you however add a patch that says what fields of kvm_kpit_state are
> protected by which locks?

Ok.  (I'll be careful to not rewrite the whole PIT while at it. :])

>                            Then this patch will just add
> 
> 	/* Protected by kvm_kpit_state lock.  */
> 
> above the reinject field.

There was no need to lock reinject in the past and v2 will hopefully
achieve it again.

> Otherwise
> 
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks.  (Might not be applicable to v2, though; sorry.)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] KVM: x86: change and fix PIT discard tick policy Radim Krčmář <rkrcmar@redhat.com> - 2016-02-03 17:30 +0100
  [PATCH 2/4] KVM: x86: refactor PIT state inject_lock Radim Krčmář <rkrcmar@redhat.com> - 2016-02-03 17:30 +0100
    Re: [PATCH 2/4] KVM: x86: refactor PIT state inject_lock Paolo Bonzini <pbonzini@redhat.com> - 2016-02-03 17:50 +0100
      Re: [PATCH 2/4] KVM: x86: refactor PIT state inject_lock Radim Krčmář <rkrcmar@redhat.com> - 2016-02-04 14:20 +0100
  [PATCH 4/4] KVM: x86: remove notifiers from PIT discard policy Radim Krčmář <rkrcmar@redhat.com> - 2016-02-03 17:30 +0100
    Re: [PATCH 4/4] KVM: x86: remove notifiers from PIT discard policy Paolo Bonzini <pbonzini@redhat.com> - 2016-02-03 18:00 +0100
      Re: [PATCH 4/4] KVM: x86: remove notifiers from PIT discard policy Radim Krčmář <rkrcmar@redhat.com> - 2016-02-04 14:20 +0100
  [PATCH 1/4] KVM: x86: fix interrupt dropping race in PIT Radim Krčmář <rkrcmar@redhat.com> - 2016-02-03 17:30 +0100
    Re: [PATCH 1/4] KVM: x86: fix interrupt dropping race in PIT Radim Krčmář <rkrcmar@redhat.com> - 2016-02-04 14:40 +0100

csiph-web