Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1326760

Re: [PATCH v3] iio: adc: Add TI ADS1015 ADC driver support

Show all headers | View raw

> Would it be more consistent to handle the mutex outside of the switch above similar
> to how it is handled in ads1015_write_raw?
>
> Also the ads1015_set_power_state(data, false) is called either way so why not just
> use one call?
>

I don't have a strong preference for that. I think across IIO drivers
we can find both coding practices.

Indeed consistency with ads1015_write_raw is a good argument. Will fix it.

I will leave the code here for one more day and then send an updated version.

thanks,
Daniel.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta <daniel.baluta@intel.com> - 2016-02-03 18:00 +0100
  Re: [PATCH v3] iio: adc: Add TI ADS1015 ADC driver support Michael Welling <mwelling@ieee.org> - 2016-02-03 19:20 +0100
    Re: [PATCH v3] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta <daniel.baluta@intel.com> - 2016-02-04 14:00 +0100
      Re: [PATCH v3] iio: adc: Add TI ADS1015 ADC driver support Jonathan Cameron <jic23@kernel.org> - 2016-02-06 19:20 +0100
  Re: [PATCH v3] iio: adc: Add TI ADS1015 ADC driver support Matt Ranostay <mranostay@gmail.com> - 2016-02-04 02:10 +0100

csiph-web