Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1326500

Re: [PATCH v5] futex: Remove requirement for lock_page in get_futex_key

Show all headers | View raw

On Wed, 3 Feb 2016, Davidlohr Bueso wrote:
> +		 * We are not calling into get_futex_key_refs() in file-backed
> +		 * cases, therefore a successful atomic_inc return below will
> +		 * guarantee that get_futex_key() will continue to imply MB (B).

Can you please make that "MB (B)" part a bit more outstanding. I really had to
search for it.

> +		 */
> +		if (WARN_ON_ONCE(!atomic_inc_not_zero(&inode->i_count))) {
> +			rcu_read_unlock();
> +			put_page(page);
> +
> +			goto again;
> +		}

Don't we need 

		smp_mb__after_atomic();

here to make it a full barrier on all architectures?

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5] futex: Remove requirement for lock_page in get_futex_key Davidlohr Bueso <dave@stgolabs.net> - 2016-02-04 07:40 +0100
  Re: [PATCH v5] futex: Remove requirement for lock_page in  get_futex_key Thomas Gleixner <tglx@linutronix.de> - 2016-02-04 10:10 +0100
    Re: [PATCH v5] futex: Remove requirement for lock_page in  get_futex_key Davidlohr Bueso <dave@stgolabs.net> - 2016-02-04 18:50 +0100
      Re: [PATCH v5] futex: Remove requirement for lock_page in  get_futex_key Thomas Gleixner <tglx@linutronix.de> - 2016-02-04 19:00 +0100
        Re: [PATCH v5] futex: Remove requirement for lock_page in  get_futex_key Ingo Molnar <mingo@kernel.org> - 2016-02-05 10:50 +0100
          Re: [PATCH v5] futex: Remove requirement for lock_page in  get_futex_key Davidlohr Bueso <dave@stgolabs.net> - 2016-02-05 19:10 +0100
            Re: [PATCH v5] futex: Remove requirement for lock_page in  get_futex_key Ingo Molnar <mingo@kernel.org> - 2016-02-06 09:30 +0100

csiph-web