Re: [PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver.

From	Yingjoe Chen <yingjoe.chen@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver.
Date	2016-02-04 08:00 +0100
Message-ID	<qYm3w-52w-13@gated-at.bofh.it> (permalink)
References	<qXxNo-38h-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-02-02 at 01:19 +0800, Liguo Zhang wrote:
> If 4GB mode is enable, we should add 4gb mode support in i2c driver.
> Set 4GB mode register to support 4GB mode.
> 
> Signed-off-by: Liguo Zhang <liguo.zhang@mediatek.com>
> ---
> change in v6:
> Remove unnecessary init for reg_4g_mode.
> change in v5:
> Use BIT_ULL() to fix kernel building warning.
> change in v4:
> Use BIT_ULL() to fix kernel building warning.
> change in v3:
> Only inline the computation of reg_4g_mode in mtk_i2c_set_4g_mode().
> change in v2:
> Define a static inline function mtk_i2c_set_4g_mode() for support 4g mode.
> ---
>  drivers/i2c/busses/i2c-mt65xx.c | 42 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)


Looks good to me, Thanks.

Reviewed-by: Yingjoe Chen <yingjoe.chen@mediatek.com>

Joe.C

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver. Liguo Zhang <liguo.zhang@mediatek.com> - 2016-02-02 02:20 +0100
  Re: [PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver. Daniel Kurtz <djkurtz@chromium.org> - 2016-02-02 04:10 +0100
  Re: [PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver. Yingjoe Chen <yingjoe.chen@mediatek.com> - 2016-02-04 08:00 +0100

csiph-web