Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1326080
| From | "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/4] rmap: introduce rmap_walk_locked() |
| Date | 2016-02-03 23:50 +0100 |
| Message-ID | <qYepm-8ec-71@gated-at.bofh.it> (permalink) |
| References | <qY7nP-3C1-3@gated-at.bofh.it> <qY7nQ-3C1-15@gated-at.bofh.it> <qYepk-8ec-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Feb 03, 2016 at 02:40:19PM -0800, Andrew Morton wrote:
> On Wed, 3 Feb 2016 18:14:16 +0300 "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:
>
> > rmap_walk_locked() is the same as rmap_walk(), but caller takes care
> > about relevant rmap lock. It only supports anonymous pages for now.
> >
> > It's preparation to switch THP splitting from custom rmap walk in
> > freeze_page()/unfreeze_page() to generic one.
> >
> > ...
> >
> > +/* Like rmap_walk, but caller holds relevant rmap lock */
> > +int rmap_walk_locked(struct page *page, struct rmap_walk_control *rwc)
> > +{
> > + /* only for anon pages for now */
> > + VM_BUG_ON_PAGE(!PageAnon(page) || PageKsm(page), page);
> > + return rmap_walk_anon(page, rwc, true);
> > +}
>
> Should be rmap_walk_anon_locked()?
I leave interface open for further extension for file mappings, once it
will be needed. Interface is mirroring plain rmap_walk()
If you prefer to rename the function, I can do it too.
--
Kirill A. Shutemov
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] thp: simplify freeze_page() and unfreeze_page() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-03 16:20 +0100
[PATCH 1/4] rmap: introduce rmap_walk_locked() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-03 16:20 +0100
Re: [PATCH 1/4] rmap: introduce rmap_walk_locked() Andrew Morton <akpm@linux-foundation.org> - 2016-02-03 23:50 +0100
Re: [PATCH 1/4] rmap: introduce rmap_walk_locked() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-03 23:50 +0100
Re: [PATCH 1/4] rmap: introduce rmap_walk_locked() Andrew Morton <akpm@linux-foundation.org> - 2016-02-04 00:00 +0100
Re: [PATCH 1/4] rmap: introduce rmap_walk_locked() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-04 15:40 +0100
[PATCH 3/4] mm: make remove_migration_ptes() beyond mm/migration.c "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-03 16:20 +0100
[PATCH 4/4] thp: rewrite freeze_page()/unfreeze_page() with generic rmap walkers "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-03 16:20 +0100
Re: [PATCH 4/4] thp: rewrite freeze_page()/unfreeze_page() with generic rmap walkers Dave Hansen <dave.hansen@intel.com> - 2016-02-03 16:50 +0100
Re: [PATCH 4/4] thp: rewrite freeze_page()/unfreeze_page() with generic rmap walkers Andrew Morton <akpm@linux-foundation.org> - 2016-02-03 23:50 +0100
Re: [PATCH 4/4] thp: rewrite freeze_page()/unfreeze_page() with generic rmap walkers "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-04 00:00 +0100
Re: [PATCH 4/4] thp: rewrite freeze_page()/unfreeze_page() with generic rmap walkers "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-04 15:40 +0100
Re: [PATCH 4/4] thp: rewrite freeze_page()/unfreeze_page() with generic rmap walkers "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-05 01:00 +0100
csiph-web