Re: [PATCH 2/2] staging: wilc1000: wilc_parse_network_info refactoring

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] staging: wilc1000: wilc_parse_network_info refactoring
Date	2016-02-04 00:10 +0100
Message-ID	<qYeII-fd-55@gated-at.bofh.it> (permalink)
References	<qKw3b-3Io-601@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Dec 27, 2015 at 11:59:57PM +0700, Ivan Safonov wrote:
> 1) Return value of this function does not used;
> 2) wilc_parse_network_info has no reasons to return an error;
> 3) kfree does not free memory if argument is NULL.
> 
> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 27 +++++----------------------
>  drivers/staging/wilc1000/coreconfigurator.h |  2 +-
>  2 files changed, 6 insertions(+), 23 deletions(-)

You sent 3 different copies of this same patch, so I don't know which to
apply :(

Please fix up and resend the series properly...

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] staging: wilc1000: wilc_parse_network_info  refactoring Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-04 00:10 +0100

csiph-web