Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1325936
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature |
| Date | 2016-02-03 21:50 +0100 |
| Message-ID | <qYcxc-6PH-21@gated-at.bofh.it> (permalink) |
| References | <qWzRf-wR-1@gated-at.bofh.it> |
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
In the patched file, I see:
if (!raw_sig) {
...
}
if (!raw_sig && save_sig) {
...
}
if (!raw_sig && sign_only) {
...
}
Can you just merge the three into one if-statement that is conditional on
!raw_sig with conditional bits inside? It might be worth moving the contents
out to its own function, but it deals with sufficient of main's context that
it might not actually be worthwhile.
David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] scripts/sign-file.c: Add support for signing with a raw signature Juerg Haefliger <juerg.haefliger@hpe.com> - 2016-01-30 10:20 +0100
Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature David Howells <dhowells@redhat.com> - 2016-02-03 21:40 +0100
Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature Juerg Haefliger <juerg.haefliger@hpe.com> - 2016-02-04 10:10 +0100
Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature David Howells <dhowells@redhat.com> - 2016-02-04 11:50 +0100
Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature David Howells <dhowells@redhat.com> - 2016-02-03 21:50 +0100
[PATCH v2] scripts/sign-file.c: Add support for signing with a raw signature Juerg Haefliger <juerg.haefliger@hpe.com> - 2016-02-04 12:20 +0100
csiph-web