Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1325923

Re: [PATCH V2 5/7] cpufreq: Merge cpufreq_offline_prepare/finish routines

From Saravana Kannan <skannan@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH V2 5/7] cpufreq: Merge cpufreq_offline_prepare/finish routines
Date 2016-02-03 21:30 +0100
Message-ID <qYcdQ-6IA-7@gated-at.bofh.it> (permalink)
References <qY6i5-2YF-3@gated-at.bofh.it> <qY6i7-2YF-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 02/03/2016 06:02 AM, Viresh Kumar wrote:
> The offline routine was separated into two halves earlier by
> 'commit 1aee40ac9c86 ("cpufreq: Invoke __cpufreq_remove_dev_finish()
> after releasing cpu_hotplug.lock");.
>
> And the reasons cited were, race issues between accessing policy's sysfs
> files and policy kobject's cleanup.
>
> That race isn't valid anymore, as we don't remove the policy & its
> kobject completely on hotplugs, but do that from ->remove() callback of
> subsys framework.
>
> These two routines can be merged back now.
>
> This is a preparatory step for the next patch, that will enforce
> policy->rwsem lock around __cpufreq_governor() routines STOP/EXIT
> sequence.

Is this stale text? Seems like this is now done in the *previous* patch?

-Saravana


-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V2 5/7] cpufreq: Merge cpufreq_offline_prepare/finish routines Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-03 15:10 +0100
  Re: [PATCH V2 5/7] cpufreq: Merge cpufreq_offline_prepare/finish  routines Saravana Kannan <skannan@codeaurora.org> - 2016-02-03 21:30 +0100
    Re: [PATCH V2 5/7] cpufreq: Merge cpufreq_offline_prepare/finish  routines Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-04 02:50 +0100

csiph-web