Re: [PATCH] init: print warning message if /dev/console failed to open

From	Peter Hurley <peter@hurleysoftware.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] init: print warning message if /dev/console failed to open
Date	2016-02-03 20:30 +0100
Message-ID	<qYbhN-67g-25@gated-at.bofh.it> (permalink)
References	<qYaYq-60k-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Alexander,

On 02/03/2016 10:58 AM, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
>  init/do_mounts.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index dea5de9..ca5da05 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -505,7 +505,9 @@ void __init change_floppy(char *fmt, ...)
>  		termios.c_lflag |= ICANON;
>  		sys_ioctl(fd, TCSETSF, (long)&termios);
>  		sys_close(fd);
> -	}
> +	} else
> +		pr_err("Warning: unable to open /dev/console.\n");

I think you should include the -fd error code as well.

Is this failure new?


Regards,
Peter Hurley

> +
>  }
>  #endif
>  
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] init: print warning message if /dev/console failed to open Alexander Kuleshov <kuleshovmail@gmail.com> - 2016-02-03 20:10 +0100
  Re: [PATCH] init: print warning message if /dev/console failed to open Pranith Kumar <bobby.prani@gmail.com> - 2016-02-03 20:20 +0100
  Re: [PATCH] init: print warning message if /dev/console failed to  open Peter Hurley <peter@hurleysoftware.com> - 2016-02-03 20:30 +0100

csiph-web