Re: [PATCH net-next] hv_netvsc: Add feature flags NETIF_F_IPV6_CSUM and NETIF_F_TSO6 for netvsc

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Tom Herbert <tom@herbertland.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] hv_netvsc: Add feature flags NETIF_F_IPV6_CSUM and NETIF_F_TSO6 for netvsc
Date	Wed, 03 Feb 2016 21:10:01 +0100
Message-ID	<qYbUt-6Aw-3@gated-at.bofh.it> (permalink)
References	<qYbKO-6ij-7@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=herbertland-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=fFEahMkQzJg9FH+ROtVGYSLp3kT+HTWkRz76xyD84kI=; b=vb4H1D6JhoAaRr/LJ6+PFUUPpcAqhr3sK6BacREJKO12o5ev5x+J8wUq66McfRc4/0 jXGNeusf2FeXuPqVbPwlB0CzLsvNOpoUp9DNSDDOU+/jFWMW0B3ShSboTRtD99lajHmm DGRzq3O2j39dvJjhoLaxzxy16e3zXYaH+PwttZ2/4bqbaiAFtV/LWs0hVSa4yNVQQkD2 CDORUxiFmN5ocu6u8OTjSn9wz5znaU8nWWft6ahJ3rzqhhir7HfX9LRxam/TRDNwiviM eG3H4biLf0dLV8S4Wvd2eLnjzIIOE/pXEXXPzegAFU7aNN5gSjOvGjo81nPYp8eHhb/R M3BA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=fFEahMkQzJg9FH+ROtVGYSLp3kT+HTWkRz76xyD84kI=; b=CH2rukBZ+Y70Tu3jg/1tpDBq1NcjCyUKneBAe8dJX2XgyINXFFfMOpcF1XKWhspibZ XUw4X8uD+X35hEnVWOIz1Zs74WQIvu6uUAUmo2dgNzjEhcJMfUUQhvl49GcIs2cu5IMp htOQv/Qw6IgRoj4T15ajYiIiUi9B06eF5OXZ7rS5EFQEg6OICmrM83rEeBIFyD5MjJMP N8KuGrjtSgZ7d4JX3bcebFMdQr/NGVoFkgILIRdRwJ4x6/OZuO2ydd698kaZmJXy85bE 2lDUQmcOo7B4LssggXHXtANAVmBnmmz/oWkQa38riH5lRIIMC2TV6e78ykwEsidLHf3X 89rA==
X-Gm-Message-State	AG10YOR480wb8fy1Cq4L8rUW5vlXw6iLkSeK4A9GkwaTQzU9M6ZfazqXzGsgJof8uBojvgdPxyw5Vkku+LzOmg==
MIME-Version	1.0
X-Received	by 10.50.29.5 with SMTP id f5mr5612571igh.65.1454529724399; Wed, 03 Feb 2016 12:02:04 -0800 (PST)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	52
Organization	linux.* mail to news gateway
X-Original-Cc	"K. Y. Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, devel@linuxdriverproject.org, Linux Kernel Network Developers <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 3 Feb 2016 12:02:04 -0800
X-Original-Message-ID	<CALx6S37M5Q9j1YUUMwbAWYim13NN4qvcG402yQT3yJfdUOyA6Q@mail.gmail.com>
X-Original-References	<1454535041-14893-1-git-send-email-sixiao@microsoft.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1325903

Show key headers only | View raw

On Wed, Feb 3, 2016 at 1:30 PM, Simon Xiao <sixiao@microsoft.com> wrote:
> 1. Adding NETIF_F_IPV6_CSUM and NETIF_F_TSO6 feature flags which are
> supported by Hyper-V platform.

NETIF_F_IPV6_CSUM and NETIF_F_IP_CSUM are being deprecated. Please
change to use NETIF_F_HW_CSUM (calling helper functions if need).

Thanks,
Tom

> 2. Cleanup the coding style of flag assignment by using macro.
>
> Signed-off-by: Simon Xiao <sixiao@microsoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> ---
>  drivers/net/hyperv/netvsc_drv.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 1d3a665..0cde741 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -43,6 +43,12 @@
>
>  #define RING_SIZE_MIN 64
>  #define LINKCHANGE_INT (2 * HZ)
> +#define NETVSC_HW_FEATURES     (NETIF_F_RXCSUM | \
> +                                NETIF_F_SG | \
> +                                NETIF_F_TSO | \
> +                                NETIF_F_TSO6 | \
> +                                NETIF_F_IP_CSUM | \
> +                                NETIF_F_IPV6_CSUM)
>  static int ring_size = 128;
>  module_param(ring_size, int, S_IRUGO);
>  MODULE_PARM_DESC(ring_size, "Ring buffer size (# of pages)");
> @@ -1081,10 +1087,8 @@ static int netvsc_probe(struct hv_device *dev,
>
>         net->netdev_ops = &device_ops;
>
> -       net->hw_features = NETIF_F_RXCSUM | NETIF_F_SG | NETIF_F_IP_CSUM |
> -                               NETIF_F_TSO;
> -       net->features = NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_SG | NETIF_F_RXCSUM |
> -                       NETIF_F_IP_CSUM | NETIF_F_TSO;
> +       net->hw_features = NETVSC_HW_FEATURES;
> +       net->features = NETVSC_HW_FEATURES | NETIF_F_HW_VLAN_CTAG_TX;
>
>         net->ethtool_ops = &ethtool_ops;
>         SET_NETDEV_DEV(net, &dev->device);
> --
> 2.5.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] hv_netvsc: Add feature flags NETIF_F_IPV6_CSUM and NETIF_F_TSO6 for netvsc Simon Xiao <sixiao@microsoft.com> - 2016-02-03 21:00 +0100
  Re: [PATCH net-next] hv_netvsc: Add feature flags NETIF_F_IPV6_CSUM  and NETIF_F_TSO6 for netvsc Tom Herbert <tom@herbertland.com> - 2016-02-03 21:10 +0100

csiph-web