Re: [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table

From	"Luis R. Rodriguez" <mcgrof@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table
Date	2016-02-03 20:00 +0100
Message-ID	<qYaOK-5HS-15@gated-at.bofh.it> (permalink)
References	<qXoTM-4WL-7@gated-at.bofh.it> <qXoTN-4WL-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 01, 2016 at 10:38:50AM -0500, Boris Ostrovsky wrote:
> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
> index c49f79e..9a239d5 100644
> --- a/drivers/xen/grant-table.c
> +++ b/drivers/xen/grant-table.c
> @@ -1147,13 +1147,13 @@ EXPORT_SYMBOL_GPL(gnttab_init);
>  
>  static int __gnttab_init(void)
>  {
> +	if (!xen_domain())
> +		return -ENODEV;
> +
>  	/* Delay grant-table initialization in the PV on HVM case */
> -	if (xen_hvm_domain())
> +	if (xen_hvm_domain() && !xen_hvmlite)
>  		return 0;
>  
> -	if (!xen_pv_domain())
> -		return -ENODEV;
> -
>  	return gnttab_init();
>  }

For instance if we had pv types generalized then this would just be a one line
addition for __gnttab_init() to support hvmlite. Much cleaner, generalizes the
extensions and gets folks thinking about the types on all calls Xen init call
sites.

  Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-01 16:50 +0100
  Re: [Xen-devel] [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests  delay initializing grant table David Vrabel <david.vrabel@citrix.com> - 2016-02-02 17:20 +0100
    Re: [Xen-devel] [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests  delay initializing grant table Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-02 17:50 +0100
  Re: [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay  initializing grant table "Luis R. Rodriguez" <mcgrof@suse.com> - 2016-02-03 20:00 +0100

csiph-web