Re: [PATCH RESEND 1/3] PCI: Add fwnode_handle to pci_sysdata

From	Bjorn Helgaas <helgaas@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND 1/3] PCI: Add fwnode_handle to pci_sysdata
Date	2016-02-03 20:00 +0100
Message-ID	<qYaOJ-5HS-3@gated-at.bofh.it> (permalink)
References	<qXNfr-6ut-3@gated-at.bofh.it> <qXNft-6ut-23@gated-at.bofh.it> <qYalH-5xv-5@gated-at.bofh.it> <qYavp-5AG-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 03, 2016 at 06:32:20PM +0000, Jake Oshins wrote:
> > -----Original Message-----
> > From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> > Sent: Wednesday, February 3, 2016 10:25 AM
> > To: Jake Oshins <jakeo@microsoft.com>
> > Cc: gregkh@linuxfoundation.org; KY Srinivasan <kys@microsoft.com>; linux-
> > kernel@vger.kernel.org; devel@linuxdriverproject.org; Haiyang Zhang
> > <haiyangz@microsoft.com>; marc.zyngier@arm.com;
> > bhelgaas@google.com; linux-pci@vger.kernel.org
> > Subject: Re: [PATCH RESEND 1/3] PCI: Add fwnode_handle to pci_sysdata
> > 
> > Hi Jake,
> > 
> > On Tue, Feb 02, 2016 at 05:41:41PM +0000, jakeo@microsoft.com wrote:

> > > diff --git a/include/linux/pci.h b/include/linux/pci.h index
> > > 27df4a6..cd05a8e 100644
> > > --- a/include/linux/pci.h
> > > +++ b/include/linux/pci.h
> > > @@ -1515,6 +1515,10 @@ static inline int pci_get_new_domain_nr(void) {
> > > return -ENOSYS; }
> > >
> > >  #include <asm/pci.h>
> > >
> > > +#ifndef pci_root_bus_fwnode
> > > +#define pci_root_bus_fwnode(bus)	((void)(bus), NULL)
> > 
> > Huh, interesting.  This is new for me; I guess the idea is that we at least
> > evaluate "bus" even when pci_root_bus_fwnode isn't defined, so the
> > compiler can catch egregious errors?
> > 
> 
> This was a suggestion by Mark Zyngier.  It made the non-x86 architectures build benignly.  If you'd like it done differently, I'm open to suggestion.

Something like "#define pci_root_bus_fwnode(bus) NULL" would be
typical.  What I'm curious about is the use of the comma operator.
I'm not opposed to it; I'm just trying to understand why it makes a
difference.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 1/3] PCI: Add fwnode_handle to pci_sysdata jakeo@microsoft.com - 2016-02-02 18:50 +0100
  Re: [PATCH RESEND 1/3] PCI: Add fwnode_handle to pci_sysdata Bjorn Helgaas <helgaas@kernel.org> - 2016-02-03 19:30 +0100
    RE: [PATCH RESEND 1/3] PCI: Add fwnode_handle to pci_sysdata Jake Oshins <jakeo@microsoft.com> - 2016-02-03 19:40 +0100
      Re: [PATCH RESEND 1/3] PCI: Add fwnode_handle to pci_sysdata Marc Zyngier <marc.zyngier@arm.com> - 2016-02-03 20:00 +0100
        RE: [PATCH RESEND 1/3] PCI: Add fwnode_handle to pci_sysdata Jake Oshins <jakeo@microsoft.com> - 2016-02-04 00:20 +0100
      Re: [PATCH RESEND 1/3] PCI: Add fwnode_handle to pci_sysdata Bjorn Helgaas <helgaas@kernel.org> - 2016-02-03 20:00 +0100

csiph-web