Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328113

Re: [PATCH v3] synopsys pcie rc generic platform driver update

Show all headers | View raw

Hi Joao,

On Fri, Feb 05, 2016 at 07:55:43PM +0000, Joao Pinto wrote:
> This patch tries to improve the host/pcie-synopsys branch including a new
> driver name, more accurate documentation and centralized link up validation.
> Other platform drivers were also updated to include the new centralized link
> up validation function.

It's true that I wanted you to incorporate a few tweaks I had made in
my pci/host-synopsys branch, but generating incremental patches on top
of that branch makes this too confusing to follow.

My pci/host-synopsys contains two patches on top of v4.5-rc1.  I would
prefer that you

  - fetch that branch,
  - make whatever edits you need, and
  - generate fresh patches based on v4.5-rc1
  
Then everybody can see the whole series at once without trying to
integrate these changes with the ones you've previously posted, and I
can start from scratch and apply those fresh patches on top of
v4.5-rc1.

It's good that you include summaries of what's changed between
versions, but if people want to see *exactly* what's changed between
your v3 and v4 postings, it's easy for them to download those series,
apply them on different branches, and git diff the branches.

Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] synopsys pcie rc generic platform driver update Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-05 21:00 +0100
  Re: [PATCH v3] synopsys pcie rc generic platform driver update Bjorn Helgaas <helgaas@kernel.org> - 2016-02-06 00:00 +0100
    Re: [PATCH v3] synopsys pcie rc generic platform driver update Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-08 12:40 +0100

csiph-web