Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread.

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread.
Date	2016-02-05 21:50 +0100
Message-ID	<qYVuh-5aD-3@gated-at.bofh.it> (permalink)
References	<qYSZu-3G7-21@gated-at.bofh.it> <qYV1g-4ZA-15@gated-at.bofh.it> <qYVaX-53w-9@gated-at.bofh.it> <qYVkB-572-5@gated-at.bofh.it> <qYVkB-572-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 5, 2016 at 12:39 PM, John Stultz <john.stultz@linaro.org> wrote:
> On Fri, Feb 5, 2016 at 12:32 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
>> On Fri, 5 Feb 2016 12:23:13 -0800 John Stultz <john.stultz@linaro.org> wrote:
>>> On Fri, Feb 5, 2016 at 12:13 PM, Andrew Morton
>>> <akpm@linux-foundation.org> wrote:
>>>>
>>>> IOW, it would be more consistent to add sys_set_timer_slack()?
>>>
>>> I'm fine with moving this way.
>>>
>>> Ruchi/Rom: Any objections to that idea?
>>>
>>> Thomas/Arjan: Any other functionality we should consider including
>>> when adding a syscall to tweak timer slack?
>>
>> A syscall is quite a bit more fuss - implement it on x86_64, provide a
>> no-op default in sys_ni.c, add a test suite into
>> tools/testing/selftests (mainly for arch maintainers), wait for the
>> various arch maintainers to wire it up.
>
> Yea. It is. And I'm not excited to start over on this, but this
> functionality has already run into trouble in the Android tree, as the
> PR_SET_TIMERSLACK_PID value has hit multiple collisions over time.  So
> this functionality upstream would help resolve that pain.
>
>> Fortunately the build system now emits little messages which tell
>> maintainers that there's a new syscall which needs looking at.
>>
>> And a manpage will be needed, but a prctl manpage patch would have been
>> needed anyway.
>
> Yea.

Could this be exposed as a writable /proc entry instead? Like the oom_* stuff?

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security

Thread

[PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread. John Stultz <john.stultz@linaro.org> - 2016-02-05 19:10 +0100
  Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. Kees Cook <keescook@chromium.org> - 2016-02-05 21:20 +0100
    Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. John Stultz <john.stultz@linaro.org> - 2016-02-05 21:20 +0100
  Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer  slack of an arbitrary thread. Andrew Morton <akpm@linux-foundation.org> - 2016-02-05 21:20 +0100
    Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. John Stultz <john.stultz@linaro.org> - 2016-02-05 21:30 +0100
      Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer  slack of an arbitrary thread. Andrew Morton <akpm@linux-foundation.org> - 2016-02-05 21:40 +0100
        Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. John Stultz <john.stultz@linaro.org> - 2016-02-05 21:40 +0100
          Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. Kees Cook <keescook@chromium.org> - 2016-02-05 21:50 +0100
            Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer  slack of an arbitrary thread. Andrew Morton <akpm@linux-foundation.org> - 2016-02-05 22:00 +0100
              Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. John Stultz <john.stultz@linaro.org> - 2016-02-05 23:40 +0100
                Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. John Stultz <john.stultz@linaro.org> - 2016-02-06 02:00 +0100
                Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer  slack of an arbitrary thread. Andrew Morton <akpm@linux-foundation.org> - 2016-02-06 03:00 +0100
                Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. John Stultz <john.stultz@linaro.org> - 2016-02-06 03:50 +0100
                Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. Arjan van de Ven <arjan@linux.intel.com> - 2016-02-06 03:20 +0100
                Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. Arjan van de Ven <arjan@linux.intel.com> - 2016-02-06 04:00 +0100
                Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack  of an arbitrary thread. John Stultz <john.stultz@linaro.org> - 2016-02-06 04:00 +0100

csiph-web