Re: [PATCH] block-dev: enable writeback cgroup support

From	Shaohua Li <shli@fb.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block-dev: enable writeback cgroup support
Date	2016-02-05 18:50 +0100
Message-ID	<qYSG6-3jH-17@gated-at.bofh.it> (permalink)
References	<qXyq7-3qn-9@gated-at.bofh.it> <qYSmK-3cK-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 05, 2016 at 12:21:39PM -0500, Tejun Heo wrote:
> On Mon, Feb 01, 2016 at 05:50:33PM -0800, Shaohua Li wrote:
> > block_dev's .writepages/.writepage already handles
> > wbc_init_bio/wbc_account_io. We only set the SB_I_CGROUPWB bit to
> > suppport writeback cgroup support.
> > 
> > Signed-off-by: Shaohua Li <shli@fb.com>
> 
> Acked-by: Tejun Heo <tj@kernel.org>
> 
> Can you please describe a bit how you tested it tho?

I'm doing a simple buffered write to a disk, assign it to a cgroup and
blk-throttle sets wbps for the disk/cgroup. then I'm watching iostat
with/without the bit set.

Thanks,
Shaohua

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] block-dev: enable writeback cgroup support Shaohua Li <shli@fb.com> - 2016-02-02 03:00 +0100
  Re: [PATCH] block-dev: enable writeback cgroup support Tejun Heo <tj@kernel.org> - 2016-02-05 18:30 +0100
    Re: [PATCH] block-dev: enable writeback cgroup support Shaohua Li <shli@fb.com> - 2016-02-05 18:50 +0100

csiph-web