Re: [PATCHv6] mm: slab: free kmem_cache_node after destroy sysfs file

From	Vladimir Davydov <vdavydov@virtuozzo.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv6] mm: slab: free kmem_cache_node after destroy sysfs file
Date	2016-02-05 18:00 +0100
Message-ID	<qYRTH-2MX-3@gated-at.bofh.it> (permalink)
References	<qYQNY-29m-19@gated-at.bofh.it> <qYRh0-2zl-23@gated-at.bofh.it> <qYRK2-2JM-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 05, 2016 at 07:44:33PM +0300, Dmitry Safonov wrote:
...
> >>@@ -2414,8 +2415,6 @@ int __kmem_cache_shrink(struct kmem_cache *cachep, bool deactivate)
> >>  int __kmem_cache_shutdown(struct kmem_cache *cachep)
> >>  {
> >>-	int i;
> >>-	struct kmem_cache_node *n;
> >>  	int rc = __kmem_cache_shrink(cachep, false);
> >>  	if (rc)
> >>@@ -2423,6 +2422,14 @@ int __kmem_cache_shutdown(struct kmem_cache *cachep)
> >>  	free_percpu(cachep->cpu_cache);
> >And how come ->cpu_cache (and ->cpu_slab in case of SLUB) is special?
> >Can't sysfs access it either? I propose to introduce a method called
> >__kmem_cache_release (instead of __kmem_cache_free_nodes), which would
> >do all freeing, both per-cpu and per-node.
> AFAICS, they aren't used by this sysfs.

They are: alloc_calls_show -> list_locations -> flush_all accesses
->cpu_slab.

Thanks,
Vladimir

> Anyway, seems reasonable, will do.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv6] mm: slab: free kmem_cache_node after destroy sysfs file Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-02-05 16:50 +0100
  Re: [PATCHv6] mm: slab: free kmem_cache_node after destroy sysfs file Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-02-05 17:20 +0100
    Re: [PATCHv6] mm: slab: free kmem_cache_node after destroy sysfs file Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-02-05 17:50 +0100
      Re: [PATCHv6] mm: slab: free kmem_cache_node after destroy sysfs file Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-02-05 18:00 +0100

csiph-web