Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1327937
| From | Alexander Shishkin <alexander.shishkin@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [QUEUED v0 16/19] stm class: Support devices with multiple instances |
| Date | 2016-02-05 17:50 +0100 |
| Message-ID | <qYRK2-2JM-27@gated-at.bofh.it> (permalink) |
| References | <qYRAm-2Gm-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
By convention, the name of the stm policy directory in configfs consists of
the device name to which it applies and the actual policy name, separated
by a dot. Now, some devices already have dots in their names that separate
name of the actual device from its instance identifier. Such devices will
result in two (or more, who can tell) dots in the policy directory name.
Existing policy code, however, will treat the first dot as the one that
separates device name from policy name, therefore failing the above case.
This patch makes the last dot in the directory name be the separator, thus
prohibiting dots from being used in policy names.
Suggested-by: Chunyan Zhang <zhang.chunyan@linaro.org>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
drivers/hwtracing/stm/policy.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/hwtracing/stm/policy.c b/drivers/hwtracing/stm/policy.c
index 94d3abfb73..1db189657b 100644
--- a/drivers/hwtracing/stm/policy.c
+++ b/drivers/hwtracing/stm/policy.c
@@ -332,10 +332,11 @@ stp_policies_make(struct config_group *group, const char *name)
/*
* node must look like <device_name>.<policy_name>, where
- * <device_name> is the name of an existing stm device and
- * <policy_name> is an arbitrary string
+ * <device_name> is the name of an existing stm device; may
+ * contain dots;
+ * <policy_name> is an arbitrary string; may not contain dots
*/
- p = strchr(devname, '.');
+ p = strrchr(devname, '.');
if (!p) {
kfree(devname);
return ERR_PTR(-EINVAL);
--
2.7.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[QUEUED v0 00/19] stm class/intel_th: Patches in my queue Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 10/19] stm class: Use a signed return type for stm_find_master_chan Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 05/19] stm class: Fix link list locking Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 01/19] stm class: Hide STM-specific options if STM is disabled Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 06/19] stm class: Fix an off-by-one in master array allocation Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 07/19] stm class: Prevent user-controllable allocations Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 02/19] intel_th: INTEL_TH should depend on HAS_DMA Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 09/19] intel_th: pci: Add Broxton SOC support Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 11/19] intel_th: Depend on HAS_IOMEM Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 12/19] intel_th: gth: Remove commented-out code Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 08/19] intel_th: pci: Add Apollo Lake SOC support Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:40 +0100 [QUEUED v0 03/19] stm class: Select CONFIG_SRCU Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:50 +0100 [QUEUED v0 18/19] intel_th: Set root device's drvdata early Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:50 +0100 [QUEUED v0 17/19] stm class: dummy_stm: Create multiple devices Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:50 +0100 [QUEUED v0 16/19] stm class: Support devices with multiple instances Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:50 +0100 [QUEUED v0 04/19] stm class: Fix locking in unbinding policy path Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:50 +0100 [QUEUED v0 19/19] intel_th: Use real device index in the node names Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:50 +0100 [QUEUED v0 13/19] intel_th: Update scratchpad bits according to enabled output activity Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:50 +0100 [QUEUED v0 15/19] intel_th: sth: Sanitize packet callback's return values Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:50 +0100 [QUEUED v0 14/19] stm class: Use driver's packet callback's return value Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-05 17:50 +0100
csiph-web