Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1327903

[PATCH 13/19] perf tools: handle spaces in file names obtained from /proc/pid/maps

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 13/19] perf tools: handle spaces in file names obtained from /proc/pid/maps
Date 2016-02-05 17:40 +0100
Message-ID <qYRAl-2Gm-5@gated-at.bofh.it> (permalink)
References <qYRqG-2CN-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Marcin Ślusarz <marcin.slusarz@gmail.com>

Steam frequently puts game binaries in folders with spaces.

Note: "(deleted)" markers are now treated as part of the file name.

Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Fixes: 6064803313ba ("perf tools: Use sscanf for parsing /proc/pid/maps")
Link: http://lkml.kernel.org/r/20160119190303.GA17579@marcin-Inspiron-7720
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 85155e91b61b..7bad5c3fa7b7 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -282,7 +282,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
 		strcpy(execname, "");
 
 		/* 00400000-0040c000 r-xp 00000000 fd:01 41038  /bin/cat */
-		n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
+		n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]\n",
 		       &event->mmap2.start, &event->mmap2.len, prot,
 		       &event->mmap2.pgoff, &event->mmap2.maj,
 		       &event->mmap2.min,
-- 
2.5.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[GIT PULL 00/19] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:30 +0100
  [PATCH 08/19] perf config: Document 'pager.<subcommand>' variables in man page Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:30 +0100
  [PATCH 13/19] perf tools: handle spaces in file names obtained from /proc/pid/maps Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:40 +0100
  [PATCH 06/19] perf config: Document 'top.children' variable in man page Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:40 +0100
  [PATCH 03/19] perf config: Document 'ui.show-headers' variable in man page Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:40 +0100
  [PATCH 09/19] perf config: Document 'kmem.default' variable in man page Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:40 +0100
  [PATCH 11/19] perf tools: Fix parallel build including 'clean' target Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:40 +0100
  [PATCH 07/19] perf config: Document 'man.viewer' variable in man page Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:40 +0100
  [PATCH 12/19] perf build tests: Do parallell builds with 'build-test' Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:40 +0100
  [PATCH 02/19] perf build tests: Move the feature related vars to the front of the make cmdline Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:40 +0100
  [PATCH 10/19] perf config: Document 'record.build-id' variable in man page Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-05 17:40 +0100

csiph-web