Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1327834

Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO access

From Robin Murphy <robin.murphy@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO access
Date 2016-02-05 16:30 +0100
Message-ID <qYQuB-22s-1@gated-at.bofh.it> (permalink)
References <qXlsT-2sn-29@gated-at.bofh.it> <qXsNJ-7L8-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 01/02/16 19:58, Stephen Boyd wrote:
> On 02/01, Robin Murphy wrote:
>> So far, we have been blindly assuming that having access to a
>> memory-mapped timer frame implies that the individual elements of that
>> frame frame are already enabled. Whilst it's the firmware's job to give
>> us non-secure access to frames in the first place, we should not rely
>> on implementations always being generous enough to also configure CNTACR
>> for those non-secure frames (e.g. [1]).
>>
>> Explicitly enable feature-level access per-frame, and verify that the
>> access we want is really implemented before trying to make use of it.
>>
>> [1]:https://github.com/ARM-software/tf-issues/issues/170
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> Tested-by: Stephen Boyd <sboyd@codeaurora.org>

Great, thanks!

Daniel, am I right in hoping this is something you'll pick up, or should 
I be resending it to arm-soc?

Thanks,
Robin.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO access Robin Murphy <robin.murphy@arm.com> - 2016-02-01 13:10 +0100
  Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO  access Mark Rutland <mark.rutland@arm.com> - 2016-02-01 14:50 +0100
  Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO  access Stephen Boyd <sboyd@codeaurora.org> - 2016-02-01 21:00 +0100
    Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO  access Robin Murphy <robin.murphy@arm.com> - 2016-02-05 16:30 +0100
      Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO  access Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-05 16:40 +0100
        Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO  access Robin Murphy <robin.murphy@arm.com> - 2016-02-05 16:40 +0100
  Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO  access Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-08 15:10 +0100
    Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO  access Marc Zyngier <marc.zyngier@arm.com> - 2016-02-08 15:10 +0100
  Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO  access Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-08 15:40 +0100

csiph-web