Re: [PATCH 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain

From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain
Date	2016-02-05 17:00 +0100
Message-ID	<qYQXE-2cP-25@gated-at.bofh.it> (permalink)
References	<qYOsO-I2-9@gated-at.bofh.it> <qYOCu-Lw-9@gated-at.bofh.it> <qYOCu-Lw-7@gated-at.bofh.it> <qYQXD-2cP-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 02/05/2016 10:50 AM, Boris Ostrovsky wrote:
>
>
>> @@ -962,33 +973,31 @@ static int 
>> scsiback_del_translation_entry(struct vscsibk_info *info,
>>                         struct ids_tuple *v)
>>   {
>>       struct v2p_entry *entry;
>> -    struct list_head *head = &(info->v2p_entry_lists);
>>       unsigned long flags;
>>         spin_lock_irqsave(&info->v2p_lock, flags);
>>       /* Find out the translation entry specified */
>> -    list_for_each_entry(entry, head, l) {
>> -        if ((entry->v.chn == v->chn) &&
>> -            (entry->v.tgt == v->tgt) &&
>> -            (entry->v.lun == v->lun)) {
>> -            goto found;
>> -        }
>> -    }
>> -
>> -    spin_unlock_irqrestore(&info->v2p_lock, flags);
>> -    return 1;
>> -
>> -found:
>> -    /* Delete the translation entry specfied */
>> -    __scsiback_del_translation_entry(entry);
>> +    entry = scsiback_chk_translation_entry(info, v);
>> +    if (entry)
>> +        __scsiback_del_translation_entry(entry);
>>         spin_unlock_irqrestore(&info->v2p_lock, flags);
>> -    return 0;
>> +    return entry == NULL;
>
> Might be better to return -ENOENT instead of 1 above and -EEXISTS if 
> entry!=NULL, given that this returns an int.

Nevermind reference to 1, it's removed. But returning an error code 
instead of a bool is still better I think.

-boris

Thread

[PATCH 0/2] xen/scsiback: correct two issues Juergen Gross <jgross@suse.com> - 2016-02-05 14:20 +0100
  [PATCH 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain Juergen Gross <jgross@suse.com> - 2016-02-05 14:30 +0100
    Re: [PATCH 2/2] xen/scsiback: avoid warnings when adding multiple  LUNs to a domain Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-05 17:00 +0100
      Re: [PATCH 2/2] xen/scsiback: avoid warnings when adding multiple  LUNs to a domain Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-05 17:00 +0100
      Re: [PATCH 2/2] xen/scsiback: avoid warnings when adding multiple  LUNs to a domain Juergen Gross <jgross@suse.com> - 2016-02-05 18:10 +0100
        Re: [PATCH 2/2] xen/scsiback: avoid warnings when adding multiple  LUNs to a domain Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-05 18:30 +0100
          Re: [PATCH 2/2] xen/scsiback: avoid warnings when adding multiple  LUNs to a domain Juergen Gross <jgross@suse.com> - 2016-02-08 13:30 +0100
  [PATCH 1/2] xen/scsiback: correct frontend counting Juergen Gross <jgross@suse.com> - 2016-02-05 14:30 +0100
    Re: [PATCH 1/2] xen/scsiback: correct frontend counting Juergen Gross <jgross@suse.com> - 2016-02-05 16:50 +0100
    Re: [PATCH 1/2] xen/scsiback: correct frontend counting Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-05 16:50 +0100

csiph-web