Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327792

Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees

Show all headers | View raw

Lubomir Rintel <lkundrak@v3.sk> writes:

> diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
[...]
> @@ -33,3 +37,17 @@
>  		brcm,function = <BCM2835_FSEL_ALT0>;
>  	};
>  };
> +
> +&usb {
> +	usb1@1 {
> +		compatible = "usb0424,9514";
> +		reg = <01>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethernet: usbether@1 {
> +			compatible = "usb0424,ec00";
> +			reg = <01>;
> +		};
> +	};
> +};

Hi,

This works for me, after making sure that your u-boot patch gets a
chance to be run (unset usbethaddr from u-boot).

Though, I am not really DT-literate, but shouldn't the ethernet block
use the PID from the ethernet device?
The usbether device is 9514 on RPi2, while ec00 is the hub.

Your patch works, but this works as well after swapping the PIDs.

Thanks

-- 
Olivier Blin - blino

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees Lubomir Rintel <lkundrak@v3.sk> - 2016-02-04 08:40 +0100
  RE: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device  trees Peter Chen <peter.chen@nxp.com> - 2016-02-04 09:30 +0100
  Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees Olivier Blin <dev@blino.org> - 2016-02-05 15:30 +0100
    Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device  trees Lubomir Rintel <lkundrak@v3.sk> - 2016-02-05 16:00 +0100
      Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees Olivier Blin <dev@blino.org> - 2016-02-05 16:10 +0100
  Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device  trees Stephen Warren <swarren@wwwdotorg.org> - 2016-02-06 05:20 +0100

csiph-web